RDK-50751: Remove HDCPProfile and move the APIs DisplayInfo #365
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reason for change: Remove HDCPProfile and move the APIs DisplayInfo Test Procedure: None Risks: Low Change-Id: I86bff2798cbd7579dab6d763079bb2d96be20e96 Signed-off-by:Anooj Cheriyan <[email protected]>
pwielders
reviewed
Aug 16, 2024
| // @property | ||
| // @brief Gets hdcp status reason as integer status code | ||
| // @param hdcpReason: hdcp status reason as intiger status code | ||
| virtual uint32_t HdcpReason(uint32_t& hdcpReason /* @out */) const = 0; |
There was a problem hiding this comment.
Inconsistency. Looks like all new methods use DHCP (capitalized) and this is the only method name, not capitalized. Suggest to align it to: HDCPReason()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for change:
Remove HDCPProfile and move the APIs DisplayInfo
Test Procedure: None
Risks: Low
Change-Id: I86bff2798cbd7579dab6d763079bb2d96be20e96 Signed-off-by:Anooj Cheriyan [email protected]