Skip to content

RDK-50751: Remove HDCPProfile and move the APIs DisplayInfo #365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

RDK-50751: Remove HDCPProfile and move the APIs DisplayInfo #365

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 45 additions & 0 deletions interfaces/IDisplayInfo.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,51 @@ namespace Exchange {
// @param name: Video output port name
virtual uint32_t PortName (string& name /* @out */) const = 0;

// @property
// @brief The status 'HDCP compliant' will return true
// if the display device is connected and HDCP is in an
// authenticated state. The internal display is intended
// for sink devices (TVs), while the connected display
// device is for streaming source devices (STBs).
// @param isHDCPCompliant: compliant/ non compliant
virtual uint32_t IsHDCPCompliant(bool& isHDCPCompliant /* @out */) const = 0;

// @property
// @brief This status indicates whether HDCP
// is enabled in the software stack. Typically,
// HDCP is enabled by default on all devices
// but can be disabled by setting a software flag.
// @param isHDCPEnabled: enabled/not enabled
virtual uint32_t IsHDCPEnabled(bool& isHDCPEnabled /* @out */) const = 0;

// @property
// @brief This field indicates the HDCP support status,
// serving as a static indicator for HDCP compatibility.
// HDCP support is enabled by default on all RDK devices,
// ensuring compatibility with protected content.
// @param isHDCPSupported: supported/not supported
virtual uint32_t IsHDCPSupported(bool& isHDCPSupported /* @out */) const = 0;

// @property
// @brief Gets hdcp status reason as integer status code
// @param hdcpReason: hdcp status reason as intiger status code
virtual uint32_t HdcpReason(uint32_t& hdcpReason /* @out */) const = 0;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistency. Looks like all new methods use DHCP (capitalized) and this is the only method name, not capitalized. Suggest to align it to: HDCPReason()


// @property
// @brief The supported HDCP version refers to the HDCP version of the host device.
// @param value: protocol
virtual uint32_t SupportedHDCPVersion (HDCPProtectionType& value /* @out */) const = 0;

// @property
// @brief Display HDCP version
// @param value: protocol
virtual uint32_t DisplayHDCPVersion (HDCPProtectionType& value /* @out */) const = 0;

// @property
// @brief Current HDCP version
// @param value: protocol
virtual uint32_t CurrentHDCPVersion (HDCPProtectionType& value /* @out */) const = 0;

};

/* @json 1.0.0 */
Expand Down
48 changes: 47 additions & 1 deletion jsonrpc/DisplayInfo.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,45 @@
"type": "string",
"enum": [ "HDROff", "HDR10", "HDR10Plus", "HDRDolbyVision", "HDRTechnicolor" ],
"example": "HDROff"
},
"ishdcpcompliant": {
"description": "The status 'HDCP compliant' will return true if the display device is connected and HDCP is in an authenticated state. The internal display is intended for sink devices (TVs), while the connected display device is for streaming source devices (STBs).",
"type": "boolean",
"example": true
},
"ishdcpenabled": {
"description": "This status indicates whether HDCP is enabled in the software stack. Typically, HDCP is enabled by default on all devices but can be disabled by setting a software flag.",
"type": "boolean",
"example": true
},
"ishdcpsupported": {
"description": "This field indicates the HDCP support status, serving as a static indicator for HDCP compatibility. HDCP support is enabled by default on all RDK devices, ensuring compatibility with protected content.",
"type": "boolean",
"example": true
},
"hdcpreason": {
"description": "Gets hdcp status reason as integer status code",
"type": "number",
"size": 32,
"example": 0
},
"supportedhdcpversion": {
"description": "The supported HDCP version refers to the HDCP version of the host device.",
"type": "string",
"enum": [ "Unencrypted", "HDCP1x", "HDCP2x"],
"example": "HDCP1x"
},
"displayhdcpversion": {
"description": "The 'Display HDCP version' refers to different HDCP versions depending on the device context: for the source device (STB), it indicates the HDCP version of the connected display, whereas for the sink device (TV), it will be the same HDCP version of the host device",
"type": "string",
"enum": [ "Unencrypted", "HDCP1x", "HDCP2x"],
"example": "HDCP1x"
},
"currenthdcpversion": {
"description": "The 'Current HDCP version' refers to the HDCP version determined based on the capabilities of both the host device and the connected display.",
"type": "string",
"enum": [ "Unencrypted", "HDCP1x", "HDCP2x"],
"example": "HDCP1x"
}
},
"required": [
Expand All @@ -69,7 +108,14 @@
"width",
"height",
"hdcpprotection",
"hdrtype"
"hdrtype",
"ishdcpcompliant",
"ishdcpenabled",
"ishdcpsupported",
"hdcpreason",
"supportedhdcpversion",
"receiverhdcpversion",
"currenthdcpversion"
]
}
}
Expand Down