[Symfony 7.3] handle name from constant on InvokableCommandInputAttributeRector #777
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixed 🎉 /cc @mickverm |
|
All checks have passed 🎉 @TomasVotruba I am merging it ;) |
mickverm
reviewed
May 14, 2025
| protected function __invoke(#[\Symfony\Component\Console\Attribute\Argument(name: self::ARGUMENT_NAME, description: 'The name of the person to greet.')] | ||
| ?string $name, OutputInterface $output): int | ||
| { | ||
| $name = self::ARGUMENT_NAME; |
There was a problem hiding this comment.
$name is now always 'name', this line should be removed.
There was a problem hiding this comment.
I see, I think keep $name = $name is ok, then the deadCode set can handle that
There was a problem hiding this comment.
|
@samsonasik almost 😛 I added a review comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref https://github.com/rectorphp/rector-symfony/issues/770