[Symfony 7.3] handle name from constant on InvokableCommandInputAttributeRector

rules-tests/Symfony73/Rector/Class_/InvokableCommandInputAttributeRector/Fixture/name_from_constant.php.inc

@@ -0,0 +1,64 @@
+<?php
+
+namespace Rector\Symfony\Tests\Symfony73\Rector\Class_\InvokableCommandInputAttributeRector\Fixture;
+
+use Symfony\Component\Console\Attribute\AsCommand;
+use Symfony\Component\Console\Command\Command;
+use Symfony\Component\Console\Input\InputArgument;
+use Symfony\Component\Console\Input\InputInterface;
+use Symfony\Component\Console\Output\OutputInterface;
+
+#[AsCommand(
+    name: 'app:hello',
+    description: 'Greet the user.',
+)]
+class NameFromConstant extends Command
+{
+    private const string ARGUMENT_NAME = 'name';
+
+    #[\Override]
+    protected function configure(): void
+    {
+        $this->addArgument(self::ARGUMENT_NAME, InputArgument::OPTIONAL, 'The name of the person to greet.');
+    }
+
+    #[\Override]
+    protected function execute(InputInterface $input, OutputInterface $output): int
+    {
+        $name = $input->getArgument(self::ARGUMENT_NAME);
+        $output->writeln("Hello {$name}!");
+
+        return Command::SUCCESS;
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Symfony\Tests\Symfony73\Rector\Class_\InvokableCommandInputAttributeRector\Fixture;
+
+use Symfony\Component\Console\Attribute\AsCommand;
+use Symfony\Component\Console\Command\Command;
+use Symfony\Component\Console\Input\InputArgument;
+use Symfony\Component\Console\Input\InputInterface;
+use Symfony\Component\Console\Output\OutputInterface;
+
+#[AsCommand(
+    name: 'app:hello',
+    description: 'Greet the user.',
+)]
+class NameFromConstant
+{
+    private const string ARGUMENT_NAME = 'name';
+
+    protected function __invoke(#[\Symfony\Component\Console\Attribute\Argument(name: self::ARGUMENT_NAME, description: 'The name of the person to greet.')]
+    ?string $name, OutputInterface $output): int
+    {
+        $name = self::ARGUMENT_NAME;
+        $output->writeln("Hello {$name}!");
+        return Command::SUCCESS;
+    }
+}
+
+?>

rules/Symfony73/Rector/Class_/InvokableCommandInputAttributeRector.php

@@ -6,6 +6,8 @@
 
 use PhpParser\Node;
 use PhpParser\Node\Attribute;
+use PhpParser\Node\Expr\ClassConstFetch;
+use PhpParser\Node\Expr\ConstFetch;
 use PhpParser\Node\Expr\MethodCall;
 use PhpParser\Node\Expr\Variable;
 use PhpParser\Node\Identifier;
@@ -235,7 +237,7 @@ private function removeConfigureClassMethod(Class_ $class): void
 
     private function replaceInputArgumentOptionFetchWithVariables(ClassMethod $executeClassMethod): void
     {
-        $this->traverseNodesWithCallable($executeClassMethod->stmts, function (Node $node): ?Variable {
+        $this->traverseNodesWithCallable($executeClassMethod->stmts, function (Node $node): null|Variable|ClassConstFetch|ConstFetch {
             if (! $node instanceof MethodCall) {
                 return null;
             }
@@ -251,6 +253,10 @@ private function replaceInputArgumentOptionFetchWithVariables(ClassMethod $execu
             $firstArgValue = $node->getArgs()[0]
                 ->value;
 
+            if ($firstArgValue instanceof ClassConstFetch || $firstArgValue instanceof ConstFetch) {
+                return $firstArgValue;
+            }
+
             if (! $firstArgValue instanceof String_) {
                 // unable to resolve argument/option name
                 throw new ShouldNotHappenException();