Update Fixtures for GetFunctionsToAsTwigFunctionAttributeRector #823
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsonasik
reviewed
Jul 17, 2025
...tor/Class_/GetFunctionsToAsTwigFunctionAttributeRector/Fixture/skip_difference_class.php.inc
Outdated
Show resolved
Hide resolved
cvergne
force-pushed
the
fix/822-GetFunctionsToAsTwigFunctionAttributeRector
branch
from
79aa083 to
5d786b3
Compare
samsonasik
reviewed
Sep 10, 2025
| { | ||
| return [ | ||
| new \Twig\TwigFunction('some_function', [DifferentClass::class, 'someFunction']), | ||
| new \Twig\TwigFunction('some_function', $this->someFunction(...)), |
There was a problem hiding this comment.
this part is fine, the one that skipped is Different::class
There was a problem hiding this comment.
Oh, I see, as not all changed, this should be skipped.
samsonasik
added a commit
that referenced
this pull request
Sep 10, 2025
|
I cherry-picked your commits at PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested in rectorphp/rector#9361, here is a draft Pull Request with :
AbstractExtension