Fix relationship validation to track endpoints for duplicate detection#27
Merged
akollegger merged 3 commits into018-pattern-path-semanticsfrom Nov 29, 2025
Merged
Conversation
… same source/target nodes Co-authored-by: akollegger <53756+akollegger@users.noreply.github.com>
Co-authored-by: akollegger <53756+akollegger@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix issues in pattern path semantics logic review
Fix relationship validation to track endpoints for duplicate detection
Nov 29, 2025
akollegger
approved these changes
Nov 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relationship identifiers were incorrectly flagged as duplicates on any reuse. Per spec, relationships can repeat in a path as long as they connect the same nodes.
Valid:
(a)-[r]->(b), (a)-[r]->(b)-[r2]->(c)—rconnects same endpointsInvalid:
(a)-[r]->(b), (a)-[r]->(c)—rconnects different targetsChanges
PatternSignaturewithsigEndpoints :: Maybe (Maybe Identifier, Maybe Identifier)to track source/target nodes for relationshipsregisterRelationshipto compare endpoints when identifier already exists — error only if endpoints differregisterPathSegmentshelper to pass node context during path traversalTests Added
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.