018 pattern path semantics#24
Merged
akollegger merged 28 commits intomainfrom Nov 29, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements semantic validation for the Gram language, introducing a new validation module that enforces pattern and path notation semantics including single definition rules, referential integrity, and consistency checks between mixed notations.
Key Changes:
- Added
Gram.Validatemodule with core validation logic for patterns and paths - Created comprehensive design documentation defining semantic rules (SEMANTICS.md and EXTENDED-SEMANTICS.md)
- Added test suite with 12 test cases covering basic patterns, path notation, and mixed notation validation
Reviewed changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated 11 comments.
Show a summary per file
| File | Description |
|---|---|
libs/gram/src/Gram/Validate.hs |
New validation module implementing symbol table, error types, and two-pass validation (registration + checking) |
libs/gram/tests/SemanticsSpec.hs |
New test suite covering basic pattern validation, path notation, and mixed notation consistency |
libs/gram/src/Gram.hs |
Updated module exports to include Gram.Validate (missing Gram.Parse export) |
libs/gram/src/Gram/CST.hs |
Added Ord instance to Identifier type for use in Map keys |
libs/gram/src/Gram/Parse.hs |
Qualified imports for Value types from Subject.Value module to avoid conflicts |
libs/gram/gram.cabal |
Added Gram.Validate module, SemanticsSpec test, and mtl dependency |
design/SEMANTICS.md |
New comprehensive documentation of pattern semantics and fundamental rules |
design/EXTENDED-SEMANTICS.md |
New detailed documentation of pattern-path integration and edge cases |
specs/018-pattern-path-semantics/*.md |
Complete specification files including spec, tasks, research, plan, quickstart, data model, and contracts |
cabal.project.local |
Configuration to enable tests |
.cursor/rules/specify-rules.mdc |
Updated recent changes section with feature reference |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
@akollegger I've opened a new pull request, #25, to work on those changes. Once the pull request is ready, I'll request review from you. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Andreas Kollegger <akollegger@gmail.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Andreas Kollegger <akollegger@gmail.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Andreas Kollegger <akollegger@gmail.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Andreas Kollegger <akollegger@gmail.com>
Co-authored-by: akollegger <53756+akollegger@users.noreply.github.com>
Update Gram.hs module documentation to include Gram.Validate
Contributor
|
@akollegger I've opened a new pull request, #26, to work on those changes. Once the pull request is ready, I'll request review from you. |
… definitions from references Co-authored-by: akollegger <53756+akollegger@users.noreply.github.com>
Co-authored-by: akollegger <53756+akollegger@users.noreply.github.com>
Fix path-pattern mixing logic in registerRelationship
Contributor
|
@akollegger I've opened a new pull request, #27, to work on those changes. Once the pull request is ready, I'll request review from you. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Andreas Kollegger <akollegger@gmail.com>
… same source/target nodes Co-authored-by: akollegger <53756+akollegger@users.noreply.github.com>
Co-authored-by: akollegger <53756+akollegger@users.noreply.github.com>
Fix relationship validation to track endpoints for duplicate detection
Contributor
|
@akollegger I've opened a new pull request, #28, to work on those changes. Once the pull request is ready, I'll request review from you. |
Co-authored-by: akollegger <53756+akollegger@users.noreply.github.com>
Fix quickstart example to use Megaparsec parse function correctly
Contributor
|
@akollegger I've opened a new pull request, #29, to work on those changes. Once the pull request is ready, I'll request review from you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.