Skip to content

Remove unused validation types and clarify cycle detection semantics#29

Closed
Copilot wants to merge 4 commits intomainfrom
copilot/sub-pr-24
Closed

Remove unused validation types and clarify cycle detection semantics#29
Copilot wants to merge 4 commits intomainfrom
copilot/sub-pr-24

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Nov 29, 2025

Addresses review feedback asking whether the suggestion was about code hygiene, code improvement, or test coverage, and whether cycle detection is correct.

Answer: This is a code hygiene fix. Cycle detection is correct by design—indirect cycles are allowed, only direct self-reference is rejected.

Changes

  • Remove unused ValidateM type alias (was never used in implementation)
  • Remove unused emptyEnv function (was never called)
  • Remove unused ValidationEnv type entirely (planned for cycle detection but unnecessary since indirect cycles are intentionally allowed)

Cycle Detection Semantics

-- Direct self-reference → rejected with SelfReference error
"[a | a]"  -- ❌ Invalid

-- Indirect cycles → allowed by design  
"[a | b], [b | a]"  -- ✅ Valid

All 18 semantics tests pass, confirming validation logic works correctly.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI mentioned this pull request Nov 29, 2025
Base automatically changed from 018-pattern-path-semantics to main November 29, 2025 15:01
Copilot AI and others added 3 commits November 29, 2025 15:03
…antics

Co-authored-by: akollegger <53756+akollegger@users.noreply.github.com>
…d in public API

Co-authored-by: akollegger <53756+akollegger@users.noreply.github.com>
Co-authored-by: akollegger <53756+akollegger@users.noreply.github.com>
Copilot AI changed the title [WIP] WIP to address feedback on 018 pattern path semantics Remove unused validation types and clarify cycle detection semantics Nov 29, 2025
Copilot AI requested a review from akollegger November 29, 2025 15:08
@akollegger akollegger closed this Nov 29, 2025
@akollegger akollegger deleted the copilot/sub-pr-24 branch November 29, 2025 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants