Skip to content

Remove unused validation types and clarify cycle detection semantics #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 4 commits into from
Closed

Remove unused validation types and clarify cycle detection semantics #29

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d27c507
Initial plan
Copilot Nov 29, 2025
3027e90
fix: remove unused ValidationEnv code and clarify cycle detection sem…
Copilot Nov 29, 2025
2810d5b
refactor: remove ValidationEnv from module exports since it's not use…
Copilot Nov 29, 2025
dfc628e
refactor: remove unused ValidationEnv type entirely to reduce dead code
Copilot Nov 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions libs/gram/src/Gram/Validate.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ module Gram.Validate
, SymbolType(..)
, DefinitionStatus(..)
, PatternSignature(..)
, ValidationEnv(..)
, ValidationError(..)
, validate
) where
Expand Down Expand Up @@ -49,10 +48,6 @@ data PatternSignature = PatternSignature
, sigEndpoints :: Maybe (Maybe Identifier, Maybe Identifier) -- (source, target) for relationships
} deriving (Show, Eq)

data ValidationEnv = ValidationEnv
{ envCurrentPath :: [Identifier] -- For cycle detection
} deriving (Show, Eq)

data ValidationError
= DuplicateDefinition Identifier
| UndefinedReference Identifier
Expand All @@ -62,15 +57,11 @@ data ValidationError
deriving (Show, Eq)

type ValidationState = (SymbolTable, [ValidationError])
type ValidateM a = State ValidationEnv a

-- | Initial state
emptySymbolTable :: SymbolTable
emptySymbolTable = Map.empty

emptyEnv :: ValidationEnv
emptyEnv = ValidationEnv []

-- | Validate a parsed Gram AST.
validate :: Gram -> Either [ValidationError] ()
validate (Gram _ patterns) =
Expand Down