Skip to content

Conversation

Danish-588
Copy link
Contributor

@Danish-588 Danish-588 commented Aug 21, 2025

This PR removes unnecessary trailing semicolons that were triggering -Wpedantic compiler warnings.

Fixes issue #2475.
Scope is minimal (good first issue).

Removed redundant semicolons from:

  • joint_limits/include/joint_limits/data_structures.hpp (lines 41–44)
  • hardware_interface/src/resource_manager.cpp (line 92)

Confirmed that code compiles cleanly without warnings.

@Danish-588 Danish-588 changed the title Remove extra semicolons fix: remove extra semicolons [-Wpedantic] Aug 21, 2025
@Danish-588 Danish-588 changed the title fix: remove extra semicolons [-Wpedantic] Remove extra semicolons [-Wpedantic] Aug 21, 2025
@christophfroehlich christophfroehlich linked an issue Aug 24, 2025 that may be closed by this pull request
8 tasks
Copy link

codecov bot commented Aug 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.21%. Comparing base (605718c) to head (c017cb8).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2478      +/-   ##
==========================================
+ Coverage   89.20%   89.21%   +0.01%     
==========================================
  Files         144      144              
  Lines       16335    16334       -1     
  Branches     1393     1393              
==========================================
+ Hits        14571    14573       +2     
+ Misses       1227     1225       -2     
+ Partials      537      536       -1     
Flag Coverage Δ
unittests 89.21% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
hardware_interface/src/resource_manager.cpp 78.61% <ø> (ø)
...nt_limits/include/joint_limits/data_structures.hpp 80.55% <100.00%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@christophfroehlich christophfroehlich merged commit 59a331e into ros-controls:master Aug 24, 2025
25 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove extra ;
2 participants