Skip to content

Conversation

mendes-jose
Copy link

@mendes-jose mendes-jose commented Feb 26, 2025

Description

This PR aims to solve the compilation error we get when messages have at least one field of type bool[].

This has been discussed in other places, like in these issues here: #445, #393, #391

Also, there has been a PR which proposes a different solution to the same problem: #411

However, I think the solution adopted in this PR here (#446) is superior:

  • it's a pure C++ solution (it does not touch the EmPy stuff)
  • it avoids creating new methods with similar names (instead it adds overloads for specific cases using enable_if_t)

Tests

The following video shows the bi-directional bridge of messages using vectors of bools based on my version of ros1_bridge:

fix-bool-vec.mp4

@mendes-jose mendes-jose changed the title Use SFINAE to add overloads that handle std::vector/std::array of bool bugfix: Use SFINAE to add overloads that handle std::vector/std::array of bool Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant