[bitreq] Make Url::append_query_pairs and preserve_fragment_from public methods#500
Open
tnull wants to merge 2 commits intorust-bitcoin:masterfrom
Open
[bitreq] Make Url::append_query_pairs and preserve_fragment_from public methods#500tnull wants to merge 2 commits intorust-bitcoin:masterfrom
Url::append_query_pairs and preserve_fragment_from public methods#500tnull wants to merge 2 commits intorust-bitcoin:masterfrom
Conversation
We previously considered `append_query_pairs` and `preserve_fragment_from` only internal methods and hence made them only `pub` when fuzzing. Unfortunately it turns out that they are very useful and we need them for downstream migration, so here we make them `pub` for everybody.
Collaborator
Author
|
@TheBlueMatt unfortunately found we need this to switch |
tnull
changed the title
append_query_pairs and preserve_fragment_from pubUrl::append_query_pairs and preserve_fragment_from public methods
tnull
added a commit
to tnull/corepc
that referenced
this pull request
Feb 11, 2026
When switching a downstream dependency to `Url` we unfortunately discovered that we need the changes in rust-bitcoin#500. Here we therefore cut another patch release to get them out.
tnull
added a commit
to tnull/corepc
that referenced
this pull request
Feb 11, 2026
When switching a downstream dependency to `Url` we unfortunately discovered that we need the changes in rust-bitcoin#500. Here we therefore cut another patch release to get them out.
TheBlueMatt
reviewed
Feb 11, 2026
Member
|
CI is sad. |
tnull
force-pushed
the
2026-02-pub-query-pairs
branch
from
a215706 to
0736073
Compare
Collaborator
Author
Should be fixed. |
tcharding
previously approved these changes
Feb 12, 2026
Member
|
Clippy wants all the |
Member
|
I have 4 hours left today, I can re-ack and merge this if you push the lint changes. And then cut the release. |
Signed-off-by: Elias Rohrer <dev@tnull.de>
tnull
force-pushed
the
2026-02-pub-query-pairs
branch
from
0736073 to
cb8d981
Compare
Collaborator
Author
Grr, didn't catch that as I only ran Anyways, amended the last commit to remove the |
tnull
added a commit
to tnull/corepc
that referenced
this pull request
Feb 12, 2026
When switching a downstream dependency to `Url` we unfortunately discovered that we need the changes in rust-bitcoin#500. Here we therefore cut another patch release to get them out. Signed-off-by: Elias Rohrer <dev@tnull.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We previously considered
append_query_pairsandpreserve_fragment_fromonly internal methods and hence made them onlypubwhen fuzzing.Unfortunately it turns out that they are very useful and we need them for downstream migration, so here we make them
pubfor everybody.