-
-
Notifications
You must be signed in to change notification settings - Fork 473
Rename fns choose_multiple* → sample*; add choose*_iter #1632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
e67fa45
to
534b292
Compare
Note: I don't think we should add I briefly considered deprecating all the |
/// println!("{:?}", choice); | ||
/// } | ||
/// ``` | ||
fn choose_iter<R>(&self, rng: &mut R) -> Option<impl Iterator<Item = &Self::Output>> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This uses RPIT, stabilised in Rust 1.75. We will need to update the MSRV to 1.85 anyway for chacha20, so I'll make a new PR for that...
CHANGELOG.md
entryFixes #1620 by:
IndexedRandom::choose_multiple*
→sample*
IteratorRandom::choose_multiple*
→sample*
IndexedRandom::choose_iter
,choose_weighted_iter
I think I'm happy to go with this. @vks, @benjamin-lieser review please.