-
Notifications
You must be signed in to change notification settings - Fork 18
[Guideline] Add safe division guideline to avoid dividing by zero #136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
felix91gr
merged 28 commits into
rustfoundation:main
from
vapdrs:feature/use-check-arithmetic
Aug 25, 2025
Merged
Changes from 6 commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
06933f9
Add checked arithmetic guidelines
vapdrs b2a3143
Add more typo ignore patterns
vapdrs 8d2392d
Remove floating point types from these guidelines
vapdrs 752ba7a
Ensure example match
vapdrs 9d1e817
Add statement to rationale justifying the Advisory
vapdrs 1ad9181
Correct typos
vapdrs ee853e0
Update comment for directive typo check
vapdrs 03d7bbc
Expound upon `unchecked_` functions
vapdrs 9dc042f
Fix grammar of wrap around
vapdrs 357c012
Change sphinx link syntax
vapdrs 36f60e2
Add link to FLS ArithmeticExpression
vapdrs 2fb316f
Correct description of unchecked function
vapdrs 9291002
Remove other mention of panics
vapdrs c9254d0
Merge remote-tracking branch 'upstream/main' into feature/use-check-a…
vapdrs b28f8ce
Narrow guideline to just integer division.
vapdrs 296df27
Remove guideline on unchecked methods
vapdrs bc8ed67
Merge remote-tracking branch 'upstream/main' into feature/use-check-a…
vapdrs fbb4429
Add remainder expression example
vapdrs c2669a7
Downgrade this to an advisory guideline
vapdrs e6c1aaf
Fix missing commas for syntax
vapdrs ef44809
Add subset tag
vapdrs 557bb5c
Merge remote-tracking branch 'upstream/main' into feature/use-check-a…
vapdrs 4a2e017
Merge remote-tracking branch 'upstream/main' into feature/use-check-a…
vapdrs 34dc8a9
Word choice as suggested by Felix
vapdrs 11662cf
Formatting
vapdrs 52834f8
Apply suggestions from code review
vapdrs cd22b39
Example clarification from code review
vapdrs e9cdb3b
Note clarity and rewording
vapdrs File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.