Implement relative Frobenius for Drinfeld modules #40432

xcaruso · 2025-07-17T15:08:03Z

This PR implements the relative Frobenius for Drinfeld modules.

📝 Checklist

The title is concise and informative.
The description explains in detail what this PR is about.
I have linked a relevant issue or discussion.
I have created tests covering the changes.
I have updated the documentation and checked the documentation preview.

⌛ Dependencies

github-actions · 2025-08-04T04:36:36Z

Documentation preview for this PR (built with commit d315182; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

kryzar

Two minor changes and then we'll be good.

src/sage/rings/function_field/drinfeld_modules/drinfeld_module.py

Co-authored-by: Antoine Leudière <[email protected]>

xcaruso · 2025-08-12T05:06:30Z

I applied your suggestions.
And also merge drinfeld_tau in this ticket for compatibility.

kryzar · 2025-08-12T18:06:49Z

It's really tedious and frustrating going through each build or test fail individually, just to inevitably note that the problem comes either from internal machinery or a contribution that was not caught. I really hope the maintainers do something about that.

PR approved.

vbraun · 2025-08-13T15:00:43Z

Why are you deleting conftest.py?

src/sage/categories/drinfeld_modules.py

xcaruso · 2025-08-13T15:38:52Z

Why are you deleting conftest.py?

Sorry. It always disappear by itself, I don't know why.

user202729 · 2025-08-16T02:26:39Z

PDF build is failing here


2025-08-15T10:05:22.7217333Z [sagemath_doc_pdf-none] [spkg-install] latexmk -pdf -dvi- -ps-  'drinfeld_modules.tex'
2025-08-15T10:05:22.7217448Z [sagemath_doc_pdf-none] [spkg-install] Rc files read:
2025-08-15T10:05:22.7217561Z [sagemath_doc_pdf-none] [spkg-install]   /etc/LatexMk
2025-08-15T10:05:22.7217672Z [sagemath_doc_pdf-none] [spkg-install]   latexmkrc
2025-08-15T10:05:22.7217923Z [sagemath_doc_pdf-none] [spkg-install] Latexmk: This is Latexmk, John Collins, 31 Jan. 2024. Version 4.83.
2025-08-15T10:05:22.7218198Z [sagemath_doc_pdf-none] [spkg-install] No existing .aux file, so I'll make a simple one, and require run of *latex.
2025-08-15T10:05:22.7218372Z [sagemath_doc_pdf-none] [spkg-install] Latexmk: applying rule 'pdflatex'...
2025-08-15T10:05:22.7218539Z [sagemath_doc_pdf-none] [spkg-install] Rule 'pdflatex':  Reasons for rerun
2025-08-15T10:05:22.7218661Z [sagemath_doc_pdf-none] [spkg-install] Category 'other':
2025-08-15T10:05:22.7218881Z [sagemath_doc_pdf-none] [spkg-install]   Rerun of 'pdflatex' forced or previously required:
2025-08-15T10:05:22.7219045Z [sagemath_doc_pdf-none] [spkg-install]     Reason or flag: 'Initial setup'
2025-08-15T10:05:22.7219133Z [sagemath_doc_pdf-none] [spkg-install] 
2025-08-15T10:05:22.7219247Z [sagemath_doc_pdf-none] [spkg-install] ------------
2025-08-15T10:05:22.7219407Z [sagemath_doc_pdf-none] [spkg-install] Run number 1 of rule 'pdflatex'
2025-08-15T10:05:22.7219513Z [sagemath_doc_pdf-none] [spkg-install] ------------
2025-08-15T10:05:22.7219627Z [sagemath_doc_pdf-none] [spkg-install] ------------
2025-08-15T10:05:22.7219988Z [sagemath_doc_pdf-none] [spkg-install] Running 'lualatex --file-line-error --interaction=batchmode  -recorder  "drinfeld_modules.tex"'
2025-08-15T10:05:22.7220095Z [sagemath_doc_pdf-none] [spkg-install] ------------
2025-08-15T10:05:22.7220336Z [sagemath_doc_pdf-none] [spkg-install] This is LuaHBTeX, Version 1.17.0 (TeX Live 2023/Debian) 
2025-08-15T10:05:22.7220513Z [sagemath_doc_pdf-none] [spkg-install]  restricted system commands enabled.
2025-08-15T10:05:22.7220856Z [sagemath_doc_pdf-none] [spkg-install] Latexmk: Missing input file 'drinfeld_modules.toc' (or dependence on it) from following:
2025-08-15T10:05:22.7221013Z [sagemath_doc_pdf-none] [spkg-install]   No file drinfeld_modules.toc.
2025-08-15T10:05:22.7221455Z [sagemath_doc_pdf-none] [spkg-install] Latexmk: Missing input file 'drinfeld_modules.ind' (or dependence on it) from following:
2025-08-15T10:05:22.7221613Z [sagemath_doc_pdf-none] [spkg-install]   No file drinfeld_modules.ind.
2025-08-15T10:05:22.7221874Z [sagemath_doc_pdf-none] [spkg-install] Latexmk: ====Undefined refs and citations with line #s in .tex file:
2025-08-15T10:05:22.7222360Z [sagemath_doc_pdf-none] [spkg-install]   Reference `sage/categories/drinfeld_modules:module-sage.categories.drinfeld_modules' on page 67 undefined on input line 5258
2025-08-15T10:05:22.7223257Z [sagemath_doc_pdf-none] [spkg-install]   Reference `sage/rings/function_field/drinfeld_modules/action:module-sage.rings.function_field.drinfeld_modules.action' on page 67 undefined on input line 5261
2025-08-15T10:05:22.7223974Z [sagemath_doc_pdf-none] [spkg-install]   Reference `sage/rings/function_field/drinfeld_modules/charzero_drinfeld_module:module-sage.rings.function_field.drinfeld_modules.charzero_drinfeld_module' on page 67 undefined on input line 5262
2025-08-15T10:05:22.7224614Z [sagemath_doc_pdf-none] [spkg-install]   Reference `sage/rings/function_field/drinfeld_modules/drinfeld_module:module-sage.rings.function_field.drinfeld_modules.drinfeld_module' on page 67 undefined on input line 5263
2025-08-15T10:05:22.7225289Z [sagemath_doc_pdf-none] [spkg-install]   Reference `sage/rings/function_field/drinfeld_modules/finite_drinfeld_module:module-sage.rings.function_field.drinfeld_modules.finite_drinfeld_module' on page 67 undefined on input line 5264
2025-08-15T10:05:22.7225997Z [sagemath_doc_pdf-none] [spkg-install]   Reference `sage/rings/function_field/drinfeld_modules/homset:module-sage.rings.function_field.drinfeld_modules.homset' on page 67 undefined on input line 5265
2025-08-15T10:05:22.7227089Z [sagemath_doc_pdf-none] [spkg-install]   Reference `sage/rings/function_field/drinfeld_modules/morphism:module-sage.rings.function_field.drinfeld_modules.morphism' on page 67 undefined on input line 5266
2025-08-15T10:05:22.7227549Z [sagemath_doc_pdf-none] [spkg-install] Latexmk: Sometimes, the -f option can be used to get latexmk
2025-08-15T10:05:22.7227873Z [sagemath_doc_pdf-none] [spkg-install]   to try to force complete processing.
2025-08-15T10:05:22.7228334Z [sagemath_doc_pdf-none] [spkg-install]   But normally, you will need to correct the file(s) that caused the
2025-08-15T10:05:22.7228620Z [sagemath_doc_pdf-none] [spkg-install]   error, and then rerun latexmk.
2025-08-15T10:05:22.7229095Z [sagemath_doc_pdf-none] [spkg-install]   In some cases, it is best to clean out generated files before rerunning
2025-08-15T10:05:22.7229303Z [sagemath_doc_pdf-none] [spkg-install]   latexmk after you've corrected the files.
2025-08-15T10:05:22.7229509Z [sagemath_doc_pdf-none] [spkg-install] Latexmk: Getting log file 'drinfeld_modules.log'
2025-08-15T10:05:22.7229696Z [sagemath_doc_pdf-none] [spkg-install] Latexmk: Examining 'drinfeld_modules.fls'
2025-08-15T10:05:22.7229874Z [sagemath_doc_pdf-none] [spkg-install] Latexmk: Examining 'drinfeld_modules.log'
2025-08-15T10:05:22.7230103Z [sagemath_doc_pdf-none] [spkg-install] Latexmk: Index file 'drinfeld_modules.idx' was written
2025-08-15T10:05:22.7230258Z [sagemath_doc_pdf-none] [spkg-install] Latexmk: References changed.
2025-08-15T10:05:22.7230403Z [sagemath_doc_pdf-none] [spkg-install] Latexmk: References changed.
2025-08-15T10:05:22.7230543Z [sagemath_doc_pdf-none] [spkg-install] Latexmk: References changed.
2025-08-15T10:05:22.7230772Z [sagemath_doc_pdf-none] [spkg-install] Latexmk: Log file says output to 'drinfeld_modules.pdf'
2025-08-15T10:05:22.7230990Z [sagemath_doc_pdf-none] [spkg-install] Latexmk: Summary of warnings from last run of *latex:
2025-08-15T10:05:22.7231166Z [sagemath_doc_pdf-none] [spkg-install]   Latex failed to resolve 7 reference(s)
2025-08-15T10:05:22.7231374Z [sagemath_doc_pdf-none] [spkg-install] Latexmk: Errors, so I did not complete making targets
2025-08-15T10:05:22.7231604Z [sagemath_doc_pdf-none] [spkg-install] Collected error summary (may duplicate other messages):
2025-08-15T10:05:22.7231961Z [sagemath_doc_pdf-none] [spkg-install]   pdflatex: Command for 'pdflatex' gave return code 1
2025-08-15T10:05:22.7232216Z [sagemath_doc_pdf-none] [spkg-install]       Refer to 'drinfeld_modules.log' and/or above output for details
2025-08-15T10:05:22.7232311Z [sagemath_doc_pdf-none] [spkg-install] 
2025-08-15T10:05:22.7232526Z [sagemath_doc_pdf-none] [spkg-install] make[4]: *** [Makefile:30: drinfeld_modules.pdf] Error 12
2025-08-15T10:05:22.7233156Z [sagemath_doc_pdf-none] [spkg-install] make[4]: Leaving directory '/sage/local/share/doc/sage/latex/en/reference/drinfeld_modules'
2025-08-15T10:05:22.7233332Z [sagemath_doc_pdf-none] [spkg-install] Error building the documentation.
2025-08-15T10:05:22.7233495Z [sagemath_doc_pdf-none] [spkg-install] Traceback (most recent call last):
2025-08-15T10:05:22.7233713Z [sagemath_doc_pdf-none] [spkg-install]   File "<frozen runpy>", line 198, in _run_module_as_main
2025-08-15T10:05:22.7233911Z [sagemath_doc_pdf-none] [spkg-install]   File "<frozen runpy>", line 88, in _run_code
2025-08-15T10:05:22.7234160Z [sagemath_doc_pdf-none] [spkg-install]   File "/sage/src/sage_docbuild/__main__.py", line 552, in <module>
2025-08-15T10:05:22.7234290Z [sagemath_doc_pdf-none] [spkg-install]     sys.exit(main())
2025-08-15T10:05:22.7234413Z [sagemath_doc_pdf-none] [spkg-install]              ^^^^^^
2025-08-15T10:05:22.7234651Z [sagemath_doc_pdf-none] [spkg-install]   File "/sage/src/sage_docbuild/__main__.py", line 548, in main
2025-08-15T10:05:22.7234761Z [sagemath_doc_pdf-none] [spkg-install]     build()
2025-08-15T10:05:22.7234993Z [sagemath_doc_pdf-none] [spkg-install]   File "/sage/src/sage_docbuild/builders.py", line 273, in pdf
2025-08-15T10:05:22.7235223Z [sagemath_doc_pdf-none] [spkg-install]     raise RuntimeError(error_message % (command, tex_dir))
2025-08-15T10:05:22.7235610Z [sagemath_doc_pdf-none] [spkg-install] RuntimeError: failed to run $MAKE all-pdf in /sage/local/share/doc/sage/latex/en/reference/drinfeld_modules

(suggestion: click through build-doc-pdf, click the cog wheel, click "View raw logs", search for error.)

or you can also build the PDF locally with

sage --docbuild reference/drinfeld_modules pdf

user202729 · 2025-08-16T02:30:36Z

It's really tedious and frustrating going through each build or test fail individually, just to inevitably note that the problem comes either from internal machinery or a contribution that was not caught. I really hope the maintainers do something about that.

PR approved.

I'm frustrated too. I tried to implement #39539 as a workaround, but it isn't working and I don't know why.

For now, I mostly just look at the meson one and if say at most 2 of them are failing then it's probably just flaky tests.

This doesn't work with build-doc or build-doc-pdf however, there's only one run of it. Doesn't help that you need to search through a huge log file for the error.

Why are you deleting conftest.py?

Sorry. It always disappear by itself, I don't know why.

Strange. After #39363 there should be no issue with it.

Unless… the pull request itself is responsible for the disappearing file.

As a workaround (I of course encourage proper fix, but we don't have enough people to look at all these bugs, unfortunately) you can

git update-index --assume-unchanged conftest.py

user202729 · 2025-08-16T03:03:04Z

Yes, documentation build failure is legitimate.

I suggest checking out the documentation preview (see message by github-actions above) to see if it renders correctly. At least I see two places where it's wrong

The easiest way to check is to click the "changes is ready" button; however this currently give some false positive, but not so much that it becomes useless.

#40530

user202729 · 2025-08-16T06:15:56Z

actually the established macro is \newcommand{\GF}[1]{\Bold{F}_{#1}}. (personally I prefer mathbb, but just for consistency with other parts of the code base)

(this macro is available for you to use)

xcaruso · 2025-08-16T06:43:07Z

Actually, we already use mathbb everywhere in the drinfeld_modules directory.
However, I can switch to GF if you think it's better.

user202729 · 2025-08-16T06:46:12Z

I mean, if people decide mathbb is better than mathbf, it's trivial to change the definition of the GF command at one place.

… but whatever, let's get this in. (if build-doc-pdf is successful and no missing character error)

kryzar · 2025-08-16T13:29:17Z

Thanks very much @user202729 for the help and many tips. It's nice.

xcaruso · 2025-08-20T05:00:50Z

Looks like the failures are again not related to the PR.
I give back a positive review. Hope this PR will be merged soon :-)

kryzar · 2025-08-20T08:08:10Z

Hope this PR will be merged soon :-)

Me too!!!

sagemathgh-40432: Implement relative Frobenius for Drinfeld modules This PR implements the relative Frobenius for Drinfeld modules. ### 📝 Checklist  - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies sagemath#40430 URL: sagemath#40432 Reported by: Xavier Caruso Reviewer(s): Antoine Leudière, Volker Braun, Xavier Caruso

Xavier Caruso added 4 commits July 17, 2025 10:42

Merge branch 'ore_not_extension' into drinfeld_tau

843a581

t -> τ

7c1a26b

declare encoding

27e890b

relative Frobenius

e82e19a

github-actions bot added the s: needs review label Jul 17, 2025

kryzar self-requested a review July 17, 2025 15:12

Xavier Caruso and others added 4 commits July 17, 2025 17:26

add the argument n, and move code in DrinfeldModule

606d762

some remaining t

2caec64

Merge branch 'develop' into drinfeld_tau

eb40b55

Merge branch 'develop' into relative_frobenius

aae7a98

kryzar reviewed Aug 11, 2025

View reviewed changes

src/sage/rings/function_field/drinfeld_modules/drinfeld_module.py Outdated Show resolved Hide resolved

src/sage/rings/function_field/drinfeld_modules/drinfeld_module.py Outdated Show resolved Hide resolved

xcaruso and others added 4 commits August 12, 2025 05:42

Update src/sage/rings/function_field/drinfeld_modules/drinfeld_module.py

b1a5d1e

Co-authored-by: Antoine Leudière <[email protected]>

Merge branch 'develop' into relative_frobenius

ba18c5f

Merge branch 'drinfeld_tau' into relative_frobenius

0079362

t -> τ

da21836

kryzar self-requested a review August 12, 2025 18:06

kryzar added s: positive review and removed s: needs review labels Aug 12, 2025

kryzar approved these changes Aug 12, 2025

View reviewed changes

vbraun added the s: needs work label Aug 13, 2025

vbraun requested changes Aug 13, 2025

View reviewed changes

src/sage/categories/drinfeld_modules.py Outdated Show resolved Hide resolved

Xavier Caruso added 3 commits August 13, 2025 17:40

remove coding utf8

15b399a

Merge branch 'drinfeld_tau' into relative_frobenius

d53a1aa

conftest.py

c7a5f2a

github-actions bot added the s: needs review label Aug 13, 2025

kryzar mentioned this pull request Aug 15, 2025

Use the variable name τ instead of t for Drinfeld modules #40430

Open

5 tasks

user202729 added s: needs work and removed s: needs review labels Aug 16, 2025

fix doctest

9308cc6

github-actions bot added s: needs review and removed s: needs work labels Aug 16, 2025

user202729 added s: positive review and removed s: needs review labels Aug 16, 2025

Xavier Caruso added 2 commits August 16, 2025 15:32

remove encoding declaration

b4b4d90

Merge branch 'drinfeld_tau' into relative_frobenius

80f46b5

github-actions bot added s: needs review and removed s: positive review labels Aug 16, 2025

xcaruso added s: positive review and removed s: needs review labels Aug 19, 2025

Xavier Caruso added 2 commits August 19, 2025 13:27

Merge branch 'develop' into drinfeld_tau

e14b7cf

Merge branch 'drinfeld_tau' into relative_frobenius

d315182

github-actions bot added s: needs review and removed s: positive review labels Aug 19, 2025

xcaruso added s: positive review and removed s: needs review labels Aug 20, 2025

Uh oh!

Implement relative Frobenius for Drinfeld modules #40432

Are you sure you want to change the base?

Implement relative Frobenius for Drinfeld modules #40432

Uh oh!

Conversation

xcaruso commented Jul 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📝 Checklist

⌛ Dependencies

Uh oh!

github-actions bot commented Aug 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kryzar left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

xcaruso commented Aug 12, 2025

Uh oh!

kryzar commented Aug 12, 2025

Uh oh!

vbraun commented Aug 13, 2025

Uh oh!

Uh oh!

xcaruso commented Aug 13, 2025

Uh oh!

user202729 commented Aug 16, 2025

Uh oh!

user202729 commented Aug 16, 2025

Uh oh!

user202729 commented Aug 16, 2025

Uh oh!

user202729 commented Aug 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

xcaruso commented Aug 16, 2025

Uh oh!

user202729 commented Aug 16, 2025

Uh oh!

kryzar commented Aug 16, 2025

Uh oh!

xcaruso commented Aug 20, 2025

Uh oh!

kryzar commented Aug 20, 2025

Uh oh!

Uh oh!

xcaruso commented Jul 17, 2025 •

edited

Loading

github-actions bot commented Aug 4, 2025 •

edited

Loading

user202729 commented Aug 16, 2025 •

edited

Loading