-
Notifications
You must be signed in to change notification settings - Fork 36
refactor signed imm to support limb based constraints BabyBear #1008
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
block by #1018 |
@@ -0,0 +1,220 @@ | |||
use crate::{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is no different for load_v2.rs/load.rs in this PR. Just a place holder for #1013
@@ -0,0 +1,142 @@ | |||
use crate::{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is no different for store_v2.rs/store.rs in this PR. Just a place holder for #1013
@@ -30,3 +30,4 @@ tracing.workspace = true | |||
[features] | |||
default = ["forbid_overflow"] | |||
forbid_overflow = [] | |||
u16limb_circuit = [] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
emulator also need this feature to interpret auipc/lui as new chip or with addi
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
To close #1012 based on #1008 ### circuit stats ```diff +---------------+---------------+---------+-------+-----------+--------+------------+---------------------+ | opcode_name | num_instances | lookups | reads | witnesses | writes | 0_expr_deg | 0_expr_sumcheck_deg | +---------------+---------------+---------+-------+-----------+--------+------------+---------------------+ - | JAL | 0 | 5 | 2 | 11 | 2 | [1: 2] | [] | + | JAL | 0 | 8 | 2 | 13 | 2 | [1: 2] | [] | - | JALR | 0 | 9 | 3 | 22 | 3 | [1: 5] | [2: 2] | + | JALR | 0 | 9 | 3 | 22 | 3 | [1: 4] | [2: 4] | +---------------+---------------+---------+-------+-----------+--------+------------+---------------------+ ```
To close #1004 and #1015
Scope
u16limb_circuit
featurespending tasks
circuit stats
benchmark
Performance shows great improvement due to
addi
lookup reduce from9
->7