feat: secure operator metrics by WithAuthenticationAndAuthorization #1110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's GuideThis PR secures the operator’s metrics endpoint by defaulting to HTTPS, integrating controller-runtime’s authentication and authorization filter, managing TLS certificates via watchers, and updating the Helm-style Kustomize overlays, RBAC, network policies, and bundle manifests to support secure metrics access. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: osmman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @osmman - I've reviewed your changes and found some issues that need to be addressed.
Blocking issues:
- Using insecureSkipVerify: true is a security risk. (link)
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🔴 Security: 1 blocking issue, 1 other issue
- 🟢 Testing: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Comment on lines
+17
to
+23
| tlsConfig: | ||
| # TODO(user): The option insecureSkipVerify: true is not recommended for production since it disables | ||
| # certificate verification, exposing the system to potential man-in-the-middle attacks. | ||
| # For production environments, it is recommended to use cert-manager for automatic TLS certificate management. | ||
| # To apply this configuration, enable cert-manager and use the patch located at config/prometheus/servicemonitor_tls_patch.yaml, | ||
| # which securely references the certificate from the 'metrics-server-cert' secret. | ||
| insecureSkipVerify: true |
There was a problem hiding this comment.
🚨 issue (security): Using insecureSkipVerify: true is a security risk.
Disabling TLS verification with insecureSkipVerify allows MITM attacks. Limit it to dev/testing, and in production enable cert-manager with valid certificates.
Comment on lines
+32
to
+36
| # [NETWORK POLICY] Protect the /metrics endpoint and Webhook Server with NetworkPolicy. | ||
| # Only Pod(s) running a namespace labeled with 'metrics: enabled' will be able to gather the metrics. | ||
| # Only CR(s) which requires webhooks and are applied on namespaces labeled with 'webhooks: enabled' will | ||
| # be able to communicate with the Webhook Server. | ||
| #- ../network-policy |
There was a problem hiding this comment.
🚨 suggestion (security): NetworkPolicy is not enabled by default; consider enabling for production.
Enabling NetworkPolicy in production helps secure metrics and webhook endpoints from unauthorized access.
osmman
force-pushed
the
tturek/migrate-kube-rbac-proxy
branch
3 times, most recently
from
7d54839 to
1b381a4
Compare
osmman
added a commit
to securesign/pipelines
that referenced
this pull request
May 14, 2025
Change RHTAS operator deployment name to rhtas-controller-manager which has been caused because of cahnges in immutable sections which causes OLM upgrade to fail. Refs: securesign/secure-sign-operator#1110
|
CI-operator and Konflux E2e tests are failing because of changes in manager's deployment name. |
osmman
force-pushed
the
tturek/migrate-kube-rbac-proxy
branch
from
1b381a4 to
1d97db4
Compare
Fix is based on changes in kubebuilder.
Refs: securesign/fbc#65 Signed-off-by: Tomas Turek <[email protected]>
osmman
force-pushed
the
tturek/migrate-kube-rbac-proxy
branch
from
1d97db4 to
5ad7d3d
Compare
|
@osmman: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: securesign/fbc#65
Summary by Sourcery
Secure operator metrics by default with HTTPS, authentication and authorization; enable dynamic TLS certificate loading for metrics and webhook servers; update manifests and RBAC to support secure metrics, and standardize labels across resources.
New Features:
Enhancements:
Build: