Skip to content

Ens best practices#139

Merged
mattaereal merged 5 commits intosecurity-alliance:developfrom
Ghadi8:ens-best-practices
May 29, 2025
Merged

Ens best practices#139
mattaereal merged 5 commits intosecurity-alliance:developfrom
Ghadi8:ens-best-practices

Conversation

@Ghadi8
Copy link
Copy Markdown
Collaborator

@Ghadi8 Ghadi8 commented May 27, 2025

This pull request introduces a new best practices framework for integrating and using the Ethereum Name Service (ENS) in applications. It adds comprehensive documentation and guidelines to ensure secure, reliable, and user-friendly ENS implementations. The key changes include updates to the project summary, the addition of a new ens-best-practices section, and detailed recommendations across several ENS-related topics.

@vercel
Copy link
Copy Markdown

vercel Bot commented May 27, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
frameworks ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 27, 2025 10:18pm

@mattaereal
Copy link
Copy Markdown
Collaborator

mattaereal commented May 27, 2025

Just a quick reminder to sign everything before committing!
Something like this should be able to amend your unsigned commits.

git rebase -i HEAD~5 (5 number of commits)
# change pick to edit for each commit you want to sign
git commit --amend --no-edit -S
git push --force

Also, can you modify the config/SUMMARY.develop as well? Summary is generated automatically based on the configuration depending on the branch

@mattaereal mattaereal self-assigned this May 27, 2025
@mattaereal mattaereal added the good first collab Come do your first collaboration! label May 27, 2025
@Ghadi8 Ghadi8 force-pushed the ens-best-practices branch from f2f441c to 1f74b4f Compare May 27, 2025 21:57
@Ghadi8 Ghadi8 force-pushed the ens-best-practices branch from 1f74b4f to 144eecb Compare May 27, 2025 22:03
@Ghadi8 Ghadi8 force-pushed the ens-best-practices branch from 310c781 to 0172935 Compare May 27, 2025 22:15
@Ghadi8 Ghadi8 force-pushed the ens-best-practices branch from 0172935 to 56604b1 Compare May 27, 2025 22:17
@mattaereal
Copy link
Copy Markdown
Collaborator

I'll try to address this today! thanks!!

@mattaereal mattaereal merged commit 6894421 into security-alliance:develop May 29, 2025
3 of 4 checks passed
@Ghadi8 Ghadi8 deleted the ens-best-practices branch August 8, 2025 14:08
frameworks-volunteer pushed a commit to frameworks-volunteer/frameworks that referenced this pull request Mar 9, 2026
* feat: ens best practices framework

* feat: small adjustments

* feat: cointype section modification

* feat: added relevant links

* feat: add ENS Best Practices to SUMMARY.develop config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first collab Come do your first collaboration!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants