Skip to content

Conversation

jamesbt365
Copy link
Member

Fixes #3375.

Adds support for the mentioned discord features,

Copied the guild features from the discord docs, its unclear what other ones exist (i could go digging for them, but its pretty useless because it'll never be non exhaustive and even their list isn't complete)

Derived Copy on RoleColours which is fine and it works on avatar decorations too but if discord adds a field its probably best to not have it copy? Let me know what you think and if i should remove this derive.

For some reason Discord didn't add nameplate image formats to the docs for whatever reason, but links said docs, so I peeked at devtools to see what the discord client is doing and found the links. I've left this under unstable though as i don't know if discord will be changing anything later. But given its just links we could probably just remove the feature flag?

Heres a peak at the object:

    "collectibles": {
        "nameplate": {
            "asset": "nameplates/nameplates/cherry_blossoms/",
            "skuId": "1349849614102036581",
            "expiresAt": null,
            "label": "COLLECTIBLES_NAMEPLATES_CHERRY_BLOSSOMS_A11Y",
            "palette": "berry"
        }
    }

And the links for example
https://cdn.discordapp.com/assets/collectibles/nameplates/nameplates/cherry_blossoms/asset.webm
https://cdn.discordapp.com/assets/collectibles/nameplates/nameplates/cherry_blossoms/static.png

The test fix I have NO idea what to do, why are we parsing a role from json here?

@github-actions github-actions bot added model Related to the `model` module. builder Related to the `builder` module. cache Related to the `cache`-feature. labels Jul 5, 2025
@jamesbt365
Copy link
Member Author

Also I have no idea how to fix the large future, have fun with that one!

@jamesbt365 jamesbt365 changed the title Features i want Gradient roles, guild tags, avatar decorations and nameplates Jul 5, 2025
Copy link
Contributor

@DPlayer234 DPlayer234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The large future seems to be due to increasing the size of some structs here, but since it only complains about the shard runner, it's probably fine to #[allow] it.

@github-actions github-actions bot added the gateway Related to the `gateway` module. label Jul 6, 2025
@jamesbt365 jamesbt365 added enhancement An improvement to Serenity. discord feature Related to Discord's functionality. needs-testing A PR that should work, but needs a functional test labels Jul 6, 2025
arqunis pushed a commit that referenced this pull request Oct 4, 2025
The remainder of #3382, rebased and cleaned up. These features all have
to do with user customization, so I think they can be merged together.

---------

Co-authored-by: jamesbt365 <[email protected]>
@arqunis arqunis closed this Oct 6, 2025
arqunis pushed a commit that referenced this pull request Oct 6, 2025
Splitting out from #3382 to rebase and fix it up.

---------

Co-authored-by: jamesbt365 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

builder Related to the `builder` module. cache Related to the `cache`-feature. discord feature Related to Discord's functionality. enhancement An improvement to Serenity. gateway Related to the `gateway` module. model Related to the `model` module. needs-testing A PR that should work, but needs a functional test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GuildMemberUpdateEvent is outdated

3 participants