-
Notifications
You must be signed in to change notification settings - Fork 625
Gradient roles, guild tags, avatar decorations and nameplates #3382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I need ideas on how to fix this properly
`GuildMemberUpdateEvent` updates
Also I have no idea how to fix the large future, have fun with that one! |
DPlayer234
reviewed
Jul 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The large future seems to be due to increasing the size of some structs here, but since it only complains about the shard runner, it's probably fine to #[allow]
it.
This was referenced Oct 2, 2025
arqunis
pushed a commit
that referenced
this pull request
Oct 4, 2025
The remainder of #3382, rebased and cleaned up. These features all have to do with user customization, so I think they can be merged together. --------- Co-authored-by: jamesbt365 <[email protected]>
arqunis
pushed a commit
that referenced
this pull request
Oct 6, 2025
Splitting out from #3382 to rebase and fix it up. --------- Co-authored-by: jamesbt365 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
builder
Related to the `builder` module.
cache
Related to the `cache`-feature.
discord feature
Related to Discord's functionality.
enhancement
An improvement to Serenity.
gateway
Related to the `gateway` module.
model
Related to the `model` module.
needs-testing
A PR that should work, but needs a functional test
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3375.
Adds support for the mentioned discord features,
Copied the guild features from the discord docs, its unclear what other ones exist (i could go digging for them, but its pretty useless because it'll never be non exhaustive and even their list isn't complete)
Derived
Copy
on RoleColours which is fine and it works on avatar decorations too but if discord adds a field its probably best to not have it copy? Let me know what you think and if i should remove this derive.For some reason Discord didn't add nameplate image formats to the docs for whatever reason, but links said docs, so I peeked at devtools to see what the discord client is doing and found the links. I've left this under unstable though as i don't know if discord will be changing anything later. But given its just links we could probably just remove the feature flag?
Heres a peak at the object:
And the links for example
https://cdn.discordapp.com/assets/collectibles/nameplates/nameplates/cherry_blossoms/asset.webm
https://cdn.discordapp.com/assets/collectibles/nameplates/nameplates/cherry_blossoms/static.png
The test fix I have NO idea what to do, why are we parsing a role from json here?