Skip to content

Draft: Add PostgresDB backend support for Lighthouse Beacon Node #7639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 12 commits into from
Closed

Draft: Add PostgresDB backend support for Lighthouse Beacon Node #7639

wants to merge 12 commits into from

Conversation

owanikin
Copy link

Issue #7638

Proposed Changes

  • Add initial scaffolding for postgres_impl.rs based on leveldb_impl.rs
  • Setup feature flag in Cargo.toml for Postgres backend
  • Add placeholder KeyValueStore trait impl using sqlx
  • Integration points for Beacon Node backend to support Postgres

Additional Info

  • This is an early draft PR meant to gather feedback on approach, structure, and trait compatibility.

michaelsproul and others added 10 commits June 23, 2025 15:07
@michaelsproul @owanikin
Change default state cache size back to 128 (sigp#7364)
45f20c9 
Closes:

- sigp#7363


  - Change default state cache size back to 128.
- Make state pruning properly LRU rather than MSU after skipping the cull-exempt states.
@macladson @owanikin
Release v7.0.1 (sigp#7374)
050abae 
Bump all required version numbers to `v7.0.1` to prepare for the next release.
@jimmygchen @owanikin
Add additional mergify rules to automate triaging (sigp#7451)
3423696 
* Add additional mergify rules to automate triaging.

* Update mergify config.
@jimmygchen @owanikin
Fix mergify infinite loop. (sigp#7463)
5dab09d 
* Fix mergify infinite loop.

* Update rule for `ready-for-review` label.

* More fix to prevent infinite loop
@jimmygchen @owanikin
Prevent mergify from updating labels while CI is still running. (sigp…
97738eb 
…#7470)
@jimmygchen @owanikin
One more attempt to fix mergify condition. (sigp#7472)
17b19f2
@jimmygchen @owanikin
Update mergify rule to not evaluate PRs that are not ready for review…
a97cca5 
… - to reduce noise and avoid updating stale PRs. (sigp#7494)
@jimmygchen @owanikin
Update mergify rules so that I can add waiting-on-author on a PR th…
6cfc265 
…at's passing CI. Remove noisy comments.
@jimmygchen @owanikin
Fix condition
d26ddcd
@jimmygchen @owanikin
Remove redundant and
ea133b3
@eserilev
Copy link
Member

I know its just an early draft PR but I think you'll need tor rebase your branch to unstable

@owanikin
Copy link
Author

I know its just an early draft PR but I think you'll need tor rebase your branch to unstable

it says Current branch add-postgres-db is up to date. after I git rebase upstream/unstable from my end, so i think its already rebased, or am I missing something?

@eserilev
Copy link
Member

I think your branch has some changes from stable

eserilev and others added 2 commits July 1, 2025 14:41
@cla-assistant CLA Assistant
Copy link

cla-assistant bot commented Jul 1, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@owanikin
Copy link
Author

owanikin commented Jul 1, 2025

I think your branch has some changes from stable

I’ve pushed a WIP PostgresDB implementation (get_bytes, put_bytes) with a test. Looking for feedback before wiring it in.

@eserilev
Copy link
Member

eserilev commented Jul 1, 2025

The PR diff is a bit messy You're reverting a bunch of changes from unstable so its hard to review this

@owanikin owanikin mentioned this pull request Jul 1, 2025
Draft
@owanikin
Copy link
Author

owanikin commented Jul 2, 2025

The PR diff is a bit messy You're reverting a bunch of changes from unstable so its hard to review this

@eserilev I’ve pushed a clean version of the PostgresDB backend implementation (with get_bytes, put_bytes, and basic tests) in the new PR. Not sure if you've had a chance to see it yet, but I'd really appreciate any early feedback on the direction before wiring it into the broader store interface. Thanks!

@eserilev
Copy link
Member

eserilev commented Jul 3, 2025 •
edited
Loading

closing in favor of #7685

@eserilev eserilev closed this Jul 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelsproul michaelsproul Awaiting requested review from michaelsproul michaelsproul will be requested when the pull request is marked ready for review michaelsproul is a code owner

@jxs jxs Awaiting requested review from jxs jxs will be requested when the pull request is marked ready for review jxs is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@owanikin @eserilev @michaelsproul @macladson @jimmygchen