fix: custom model options in Conversation.chain()
#1212
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Normally,
llm prompt ...
calls useModel.prompt()
, which takes model options asModel.prompt(..., **options)
. However,llm prompt ...
calls with tools (or other configurations that require a conversation) useConversation.chain()
, which takes model options asConversation.chain(..., options: Optional[dict] = None)
. This causes those calls to fail with invalid options when custom model options are provided.An easy way to trigger this error is via a custom
provider
option for OpenRouter models via the llm-openrouter plugin.There is no equivalent error when tools are not used:
With this fix, we can successfully prompt with the tool call: