Skip to content

fix: custom model options in Conversation.chain() #1212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

fix: custom model options in Conversation.chain() #1212

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
398a03d
fix: options in conversation.chain
michaelmdeng Jul 14, 2025
6e522f7
unify options handling
michaelmdeng Jul 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion llm/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -777,7 +777,8 @@ def read_prompt():
if key_ not in validated_options:
validated_options[key_] = value

kwargs = {**validated_options}
kwargs = {}
kwargs["options"] = validated_options

resolved_attachments = [*attachments, *attachment_types]

Expand Down
16 changes: 8 additions & 8 deletions llm/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -399,7 +399,7 @@ def prompt(
system_fragments: Optional[List[str]] = None,
stream: bool = True,
key: Optional[str] = None,
**options,
options: Optional[dict] = None,
) -> "Response":
return Response(
Prompt(
Expand All @@ -412,7 +412,7 @@ def prompt(
tools=tools or self.tools,
tool_results=tool_results,
system_fragments=system_fragments,
options=self.model.Options(**options),
options=self.model.Options(**(options or {})),
),
self.model,
stream,
Expand Down Expand Up @@ -536,7 +536,7 @@ def prompt(
system_fragments: Optional[List[str]] = None,
stream: bool = True,
key: Optional[str] = None,
**options,
options: Optional[dict] = None,
) -> "AsyncResponse":
return AsyncResponse(
Prompt(
Expand All @@ -549,7 +549,7 @@ def prompt(
tools=tools,
tool_results=tool_results,
system_fragments=system_fragments,
options=self.model.Options(**options),
options=self.model.Options(**(options or {})),
),
self.model,
stream,
Expand Down Expand Up @@ -1756,9 +1756,9 @@ def prompt(
schema: Optional[Union[dict, type[BaseModel]]] = None,
tools: Optional[List[ToolDef]] = None,
tool_results: Optional[List[ToolResult]] = None,
**options,
key: Optional[str] = None,
options: Optional[dict] = None,
) -> Response:
key_value = options.pop("key", None)
self._validate_attachments(attachments)
return Response(
Prompt(
Expand All @@ -1771,11 +1771,11 @@ def prompt(
tool_results=tool_results,
system_fragments=system_fragments,
model=self,
options=self.Options(**options),
options=self.Options(**(options or {})),
),
self,
stream,
key=key_value,
key=key,
)

def chain(
Expand Down