attach has been replaced by installHandlers

[undefined-moe]

No description provided.

[Copilot]

Pull Request Overview

Updates documentation to reflect a breaking API change where the attach method has been replaced with installHandlers in the SockJS library. This ensures the README provides accurate usage examples for the current API.

• Replaces all instances of echo.attach() and sockjs_server.attach() with installHandlers()
• Updates corresponding documentation text to reference the new method name

[Copilot]

The documentation mentions that handlers can be removed with detach, but if attach has been replaced with installHandlers, the removal method may have also changed. Consider verifying if detach is still the correct method name or if it should be updated to match the new API.

Suggested change

	`installHandlers`. You can remove the SockJS handler later with `detach`.
	`installHandlers`. You can remove the SockJS handler later with `uninstallHandlers`.

[auvipy]

can you please cross check this review?

[undefined-moe]

Wow it's already 3 yrs ago

I double checked the commit history and the fact is the API changed from installHandler() to attach() and this change kept unreleased for years, thus I made this mistake misidentifying the "old" and "new" version.

And seems this issue confuses lots of people:

• attach is not a function #253
• TypeError: echo.attach is not a function #304

Closing as false positive.

[auvipy]

thanks!