Skip to content

attach has been replaced by installHandlers #299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

attach has been replaced by installHandlers #299

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ echo.on('connection', function(conn) {
});

const server = http.createServer();
echo.attach(server);
echo.installHandlers(server);
server.listen(9999, '0.0.0.0');
```

Expand Down Expand Up @@ -181,7 +181,7 @@ Once you have create `Server` instance you can hook it to the

```javascript
var http_server = http.createServer();
sockjs_server.attach(http_server);
sockjs_server.installHandlers(http_server);
http_server.listen(...);
```

Expand All @@ -197,7 +197,7 @@ and emits following event:
All http requests that don't go under the path selected by `prefix`
will remain unanswered and will be passed to previously registered
handlers. You must install your custom http handlers before calling
`attach`. You can remove the SockJS handler later with `detach`.
`installHandlers`. You can remove the SockJS handler later with `detach`.
Copy link
Preview

Copilot AI Aug 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The documentation mentions that handlers can be removed with detach, but if attach has been replaced with installHandlers, the removal method may have also changed. Consider verifying if detach is still the correct method name or if it should be updated to match the new API.

Suggested change
`installHandlers`. You can remove the SockJS handler later with `detach`.
`installHandlers`. You can remove the SockJS handler later with `uninstallHandlers`.

Copilot uses AI. Check for mistakes.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please cross check this review?


## Connection instance

Expand Down