fix: do not display None in LCA_Database repr#3923
Open
haoyu-haoyu wants to merge 1 commit intosourmash-bio:latestfrom
Open
fix: do not display None in LCA_Database repr#3923haoyu-haoyu wants to merge 1 commit intosourmash-bio:latestfrom
haoyu-haoyu wants to merge 1 commit intosourmash-bio:latestfrom
Conversation
When LCA_Database is created without loading from a file, self.filename
is None, causing repr to show LCA_Database('None'). Return
LCA_Database() instead when filename is unset.
Closes sourmash-bio#1193
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
LCA_Databaseis created without loading from a file,self.filenameisNone, causingrepr()to showLCA_Database('None')instead of something sensible.Before:
LCA_Database('None')After:
LCA_Database()One-line change in
src/sourmash/lca/lca_db.py.Closes #1193