Preserve url parameters after oidc redirect #976
Merged
+117
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ects Co-authored-by: contact <[email protected]>
Co-authored-by: contact <[email protected]>
|
@cursor review |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no bugs!
Bugbot free trial expires on August 9, 2025
Learn more in the Cursor dashboard.
Co-authored-by: contact <[email protected]>
Co-authored-by: contact <[email protected]>
lovasoa
deleted the
cursor/preserve-url-parameters-after-oidc-redirect-2c78
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preserve query parameters during OIDC authentication redirects to maintain user context.
Previously, the
initial_urlstored in the OIDC state only captured the URL path, causing query parameters to be lost upon redirect back from the OIDC provider. This PR modifies the OIDC flow to capture the full URI, including query parameters, and introduces robust URL validation (build_safe_redirect_url,validate_redirect_url) to prevent open redirect vulnerabilities while preserving the original user intent.Open in Web • Open in Cursor • Open Docs