Add models and routes for reporting dataset lookup errors #1134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ponyisi
requested review from
Copilot,
BenGalewsky,
gordonwatts and
MattShirley
There was a problem hiding this comment.
Pull Request Overview
This PR adds functionality to handle and report dataset lookup errors in the ServiceX application. It introduces a new endpoint for receiving error notifications from the dataset lookup service and updates the data models to support error tracking.
- Adds a new
/servicex/internal/transformation/<dataset_id>/errorendpoint for reporting dataset lookup failures - Extends the
DatasetStatusenum with three new error states:does_not_exist,bad_name, andinternal_failure - Adds a new
TransformStatus.bad_datasetstate to mark transformations that fail due to dataset issues
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| servicex_app/routes.py | Registers the new FilesetError resource and endpoint |
| servicex_app/resources/internal/fileset_error.py | Implements the error handling endpoint with dataset status updates and transformation cleanup |
| servicex_app/models.py | Extends DatasetStatus and TransformStatus enums with new error states |
|
Actually we already have the endpoint for querying dataset status so all that's needed is the tests |
gordonwatts
requested changes
Aug 5, 2025
| @@ -157,6 +157,7 @@ class TransformStatus(Enum): | |||
| complete = ("Complete", True) | |||
| fatal = ("Fatal", True) | |||
| canceled = ("Canceled", True) | |||
| bad_dataset = ("Bad Dataset", True) | |||
There was a problem hiding this comment.
Maybe I'm just getting going in the review here, but shouldn't empty be here?
There was a problem hiding this comment.
? I don't think "existing but empty" dataset should be an error condition?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Companion to ssl-hep/ServiceX_DID_Finder_lib#38 . Adds a new dataset lookup failure endpoint and updates models as necessary. Still missing an endpoint to query what the error was (for client information) and tests.