-
-
Notifications
You must be signed in to change notification settings - Fork 23
Add models and routes for reporting dataset lookup errors #1134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
ponyisi
wants to merge
1
commit into
develop
Choose a base branch
from
more-lookup-failure-information
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
118 changes: 118 additions & 0 deletions
118
servicex_app/servicex_app/resources/internal/fileset_error.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,118 @@ | ||
# Copyright (c) 2025, IRIS-HEP | ||
# All rights reserved. | ||
# | ||
# Redistribution and use in source and binary forms, with or without | ||
# modification, are permitted provided that the following conditions are met: | ||
# | ||
# * Redistributions of source code must retain the above copyright notice, this | ||
# list of conditions and the following disclaimer. | ||
# | ||
# * Redistributions in binary form must reproduce the above copyright notice, | ||
# this list of conditions and the following disclaimer in the documentation | ||
# and/or other materials provided with the distribution. | ||
# | ||
# * Neither the name of the copyright holder nor the names of its | ||
# contributors may be used to endorse or promote products derived from | ||
# this software without specific prior written permission. | ||
# | ||
# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" | ||
# AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE | ||
# IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE | ||
# DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE | ||
# FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL | ||
# DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR | ||
# SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER | ||
# CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, | ||
# OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE | ||
# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. | ||
from flask import request, current_app | ||
|
||
from servicex_app.models import ( | ||
Dataset, | ||
db, | ||
TransformRequest, | ||
TransformStatus, | ||
DatasetStatus, | ||
) | ||
from servicex_app.resources.servicex_resource import ServiceXResource | ||
|
||
from datetime import datetime, timezone | ||
|
||
|
||
class FilesetError(ServiceXResource): | ||
@classmethod | ||
def make_api(cls, lookup_result_processor, transformer_manager): | ||
cls.lookup_result_processor = lookup_result_processor | ||
cls.transformer_manager = transformer_manager | ||
return cls | ||
|
||
def put(self, dataset_id): | ||
summary = request.get_json() | ||
dataset = Dataset.find_by_id(int(dataset_id)) | ||
|
||
if dataset is None: | ||
current_app.logger.info( | ||
"Dataset lookup error received for unknown dataset", | ||
extra={ | ||
"dataset_id": dataset_id, | ||
"error-type": summary["error-type"], | ||
"message": summary["message"], | ||
}, | ||
) | ||
return | ||
|
||
current_app.logger.info( | ||
"Error in file lookup", | ||
extra={ | ||
"dataset_id": dataset_id, | ||
"elapsed-time": summary["elapsed-time"], | ||
"error-type": summary["error-type"], | ||
"message": summary["message"], | ||
}, | ||
) | ||
|
||
dataset.lookup_status = DatasetStatus(summary["error-type"]) | ||
dataset.stale = True # Repeat lookup if we try again | ||
db.session.commit() | ||
|
||
# shut down related transformations. Nothing good can come of letting them | ||
# continue to run | ||
namespace = current_app.config["TRANSFORMER_NAMESPACE"] | ||
for running_request in TransformRequest.lookup_running_by_dataset_id( | ||
int(dataset_id) | ||
): | ||
running_request.status = TransformStatus.bad_dataset | ||
running_request.finish_time = datetime.now(tz=timezone.utc) | ||
self.transformer_manager.shutdown_transformer_job( | ||
running_request.request_id, namespace | ||
) | ||
current_app.logger.info( | ||
"Shutting down transformer because of dataset lookup problem", | ||
extra={ | ||
"dataset_id": dataset_id, | ||
"elapsed-time": summary["elapsed-time"], | ||
"error-type": summary["error-type"], | ||
"message": summary["message"], | ||
"requestId": running_request.request_id, | ||
}, | ||
) | ||
|
||
# Tell any other transform that was waiting for the lookup to complete | ||
# not to expect to run | ||
for pending_transform in TransformRequest.lookup_pending_on_dataset( | ||
int(dataset_id) | ||
): | ||
pending_transform.status = TransformStatus.bad_dataset | ||
pending_transform.finish_time = datetime.now(tz=timezone.utc) | ||
current_app.logger.info( | ||
"Shutting down transformer because of dataset lookup problem", | ||
extra={ | ||
"dataset_id": dataset_id, | ||
"elapsed-time": summary["elapsed-time"], | ||
"error-type": summary["error-type"], | ||
"message": summary["message"], | ||
"requestId": pending_transform.request_id, | ||
}, | ||
) | ||
|
||
db.session.commit() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe I'm just getting going in the review here, but shouldn't
empty
be here?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
? I don't think "existing but empty" dataset should be an error condition?