Skip to content

Conversation

@iurii-ssv
Copy link
Contributor

@iurii-ssv iurii-ssv commented Aug 20, 2025

Relevant discussion - ssvlabs/ssv#2453 (comment)

@iurii-ssv iurii-ssv requested a review from oleg-ssvlabs August 20, 2025 10:08
@MatusKysel MatusKysel requested a review from Copilot August 25, 2025 08:19
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request renames log fields to align with the latest SSV changes by introducing a new qbft_round field while maintaining backward compatibility with the existing round field. The changes ensure the analyzer can handle both old and new log formats during the transition period.

  • Adds QBFTRound field to log entry structs while keeping the deprecated Round field for backward compatibility
  • Updates condition checks to accept either Round == 1 or QBFTRound == 1 in service analyzers
  • Updates test cases to use the new qbft_round field format

Reviewed Changes

Copilot reviewed 7 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
internal/analyzer/parser/prepare/log.go Adds QBFTRound field with deprecation comment for Round field
internal/analyzer/parser/prepare/service.go Updates condition to check both Round and QBFTRound fields
internal/analyzer/parser/prepare/log_test.go Updates test JSON data and expected values to use qbft_round
internal/analyzer/parser/consensus/service.go Adds QBFTRound field and updates condition logic
internal/analyzer/parser/commit/log.go Adds QBFTRound field with deprecation comment for Round field
internal/analyzer/parser/commit/service.go Updates condition to check both Round and QBFTRound fields
internal/analyzer/parser/commit/log_test.go Updates test JSON data and expected values to use qbft_round

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@iurii-ssv iurii-ssv merged commit c7ea2ff into main Aug 25, 2025
4 checks passed
@iurii-ssv iurii-ssv deleted the rename-log-fields-according-to-latest-ssv-changes branch August 25, 2025 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants