duties: correct logger usage (part 2)

[iurii-ssv]

This is a follow-up to #2400 to address the following:

• to add missing log-fields, remove duplicate ones
• to standardize/refactor the way we set up the logger with all the necessary context (slot, dutyID, etc.) - so it's very clear what fields are added in every case; This is to make sure there won't be a "(part 3)" necessary
• also resolves logs: events should have slot numbers (similar to all other message types) #2452 - this is the simplest way to make logger work properly after duties: correct logger usage #2400 was merged (without this change the complexity of handling Event message-type is just too much to deal with, we have to "untangle this code sooner-or-later" in order to implement logs: duty_trace_id #1828 and since duties: correct logger usage #2400 is already merged - this is the best time to do it)

[greptile-apps]

Greptile Summary

This PR continues the effort from PR #2400 to standardize logger usage across the SSV validator codebase. The changes refactor message handling throughout the validator and committee components by:

Core Interface Changes:

• Replacing HandleMessage method calls with EnqueueMessage across validators and committees
• Removing logger parameters from message handling interfaces, allowing each component to establish its own properly contextualized logger

Logger Standardization:

• Implementing consistent logger setup patterns where all relevant context fields (messageType, messageID, role, slot, dutyID, committeeID) are established upfront at the beginning of message processing functions
• Moving away from passing loggers between components to having each validator/committee create structured loggers with comprehensive field context
• Eliminating helper methods like fetchTraceContext, withDutyID, and buildTraceContext in favor of direct field additions for clearer code flow

Architectural Improvements:

• Moving duty ID calculation and storage earlier in the StartDuty process to ensure availability for logging
• Centralizing all logger context setup in ProcessMessage methods rather than scattered throughout different code paths
• Updating test files to use standardized log.TestLogger(t) instead of manual zap logger creation

The changes maintain the same core functionality while establishing a clear, maintainable pattern for logging that ensures all duty execution operations have consistent observability context. This refactoring supports better debugging and monitoring of distributed validator operations by guaranteeing that related log entries contain the same contextual information regardless of the processing path taken.

Confidence score: 4/5

• This PR is safe to merge with minimal risk as it primarily focuses on logging improvements without changing core business logic
• Score reflects thorough refactoring of logging patterns with consistent implementation across multiple components, though some minor inconsistencies remain
• Pay attention to error handling changes in slot extraction where errors are now silently ignored for event messages

Context used:

Rule - Prefer shorter, clearer names for methods and constants. If one condition implies another (e.g., attesting implies participating), use the more specific name rather than combining both concepts. (link)

_{6 files reviewed, 1 comment}

_{Edit Code Review Bot Settings | Greptile}

[codecov]

Codecov Report

❌ Patch coverage is 15.55556% with 38 lines in your changes missing coverage. Please review.
✅ Project coverage is 55.8%. Comparing base (3620734) to head (e0066fa).
⚠️ Report is 30 commits behind head on stage.

Files with missing lines	Patch %	Lines
observability/log/fields/fields.go	0.0%	17 Missing ⚠️
observability/log/fields/format.go	0.0%	10 Missing ⚠️
operator/validator/controller.go	0.0%	6 Missing ⚠️
observability/log/fields/duty_id.go	0.0%	4 Missing ⚠️
message/validation/logger_fields.go	66.6%	1 Missing ⚠️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[greptile-apps]

Greptile Summary

This PR is part 2 of a comprehensive logging refactoring effort focused on standardizing logger usage across the SSV protocol codebase. The changes address three main objectives: adding missing log fields and removing duplicates, standardizing logger setup with consistent context fields (slot, dutyID, etc.), and resolving issue #2452 to ensure Event-type messages have proper slot numbers for tracing.

The refactoring includes several key architectural changes:

Message Type Cleanup: Removed unused SSVSyncMsgType constant and related code, simplifying the message type system to focus on actively used types (SSVEventMsgType, SSVConsensusMsgType, SSVPartialSignatureMsgType).

Field Naming Standardization: Systematically replaced generic field names with more specific QBFT-prefixed variants (fields.Round() → fields.QBFTRound(), fields.Height() → fields.QBFTHeight()) to avoid ambiguity between different types of rounds/heights in the system.

Logger Setup Centralization: Refactored message handling methods (HandleMessage → EnqueueMessage) to centralize logger context setup at the highest entry points (Validator.ProcessMessage, Committee.ProcessMessage). This ensures all log entries have consistent contextual fields from the earliest possible moment.

Duty ID Management: Moved from a hashmap-based duty ID caching approach to on-demand computation using new centralized functions (BuildDutyID, BuildCommitteeDutyID). This eliminates complex state management and makes duty IDs available for all message types including Events.

Code Organization: Created new utility files (observability/log/fields/duty_id.go, observability/log/fields/format.go) to consolidate formatting logic and removed unused constants/functions from the main fields package.

Observability Improvements: Removed duplicate trace attributes that were being logged elsewhere and standardized time field handling (StartTimeUnixMilli → SlotStartTime with proper time.Time type).

These changes prepare the codebase for implementing duty trace IDs (issue #1828) by establishing consistent logging patterns and ensuring all duty-related operations have proper contextual information for debugging and monitoring in the distributed consensus system.

Confidence score: 4/5

• This PR involves extensive refactoring of logging infrastructure with potential impact on debugging capabilities if not thoroughly tested
• Score reflects comprehensive changes to logging patterns that could affect troubleshooting if field names or context are incorrect
• Pay close attention to test files and ensure all logger usage patterns are consistently applied across the codebase

Context used:

Rule - Prefer shorter, clearer names for methods and constants. If one condition implies another (e.g., attesting implies participating), use the more specific name rather than combining both concepts. (link)

_{28 files reviewed, no comments}

_{Edit Code Review Bot Settings | Greptile}

[oleg-ssvlabs]

I left few questions. Great changes!

[Copilot]

Pull Request Overview

This PR refactors logger usage throughout the SSV codebase to standardize and improve how logging context (slot, dutyID, runner roles, etc.) is set up and maintained. The refactoring consolidates logger field management, introduces new utility functions for building duty IDs and formatting fields, and removes redundant logging code patterns.

• Standardizes logger field setup across validator and committee message handling
• Introduces helper functions for building duty IDs and formatting fields consistently
• Removes duplicate or redundant logger context setup code

Reviewed Changes

Copilot reviewed 33 out of 34 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
scripts/spec-alignment/differ.config.yaml	Adds new approved changes to the configuration
protocol/v2/types/messages.go	Updates comments for EventType constants
protocol/v2/ssv/validator/validator_queue.go	Refactors HandleMessage to EnqueueMessage with standardized logger setup
protocol/v2/ssv/validator/validator.go	Removes dutyIDs map and simplifies ProcessMessage logger setup
protocol/v2/ssv/validator/timer.go	Updates field name from Role to RunnerRole
protocol/v2/ssv/validator/non_committee_validator.go	Updates field names and error messages
protocol/v2/ssv/validator/duty_executor.go	Simplifies logger setup and removes redundant code
protocol/v2/ssv/validator/committee_queue_test.go	Updates test logger setup and method calls
protocol/v2/ssv/validator/committee_queue.go	Refactors HandleMessage to EnqueueMessage with improved context
protocol/v2/ssv/validator/committee.go	Major refactoring of logger setup and trace context building
protocol/v2/ssv/runner/*.go	Updates field names from Height/Round to QBFTHeight/QBFTRound
protocol/v2/ssv/queue/messages.go	Improves Slot() method error handling
protocol/v2/qbft/instance/*.go	Updates logging field names for consistency
protocol/v2/message/msg.go	Removes unused SSVSyncMsgType constant
operator/validator/controller*.go	Updates method calls and field names
operator/duties/scheduler.go	Updates field names for consistency
observability/log/fields/*.go	Major refactoring of field functions and formats
message/validation/*.go	Updates field names for consistency
exporter/api/query_handlers.go	Updates field name usage

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}