Skip to content

Aggregator Committee - Fix committee runners management #597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MatheusFranco99 merged 75 commits into from
Jan 8, 2026
Merged

Aggregator Committee - Fix committee runners management #597

MatheusFranco99 merged 75 commits into from
Jan 8, 2026

Conversation

@MatheusFranco99
Copy link
Contributor

@MatheusFranco99 MatheusFranco99 commented Jan 2, 2026

Overview

This PR fixes the Committee class to correctly manage CommitteeRunners and AggregatorCommitteeRunners.

@MatheusFranco99
remove aggregatorCommittee from BeaconRole
877ad54
@MatheusFranco99
remove aggregator and scc roles
6042b46
@MatheusFranco99
remove agg and scc from ValidatorConsensusData
43c258c
@MatheusFranco99
generate ssz encoding
77cafc6
@MatheusFranco99
align testingutils to remove reference to agg and scc alone
c29cab4
@MatheusFranco99
add agg committee consensus data tests (and remove agg and scc from v…
d0fe1b7 
…alidator consensus data tests)
@MatheusFranco99
generate types JSON tests
80d2575
@MatheusFranco99
drop agg and scc runners; fix agg committee runner issue
15c0097
@MatheusFranco99
align testingutils for agg committee tests
3a90436
@MatheusFranco99
value check tests
eb2603b
@MatheusFranco99
preconsensus tests
2f36539
@MatheusFranco99
post consensus tests
35494fe
@MatheusFranco99
duties tests
29f8546
@MatheusFranco99
runner construction tests
0d94a9f
@MatheusFranco99
consensus tests
5522634
@MatheusFranco99
happy flow test
1eea4d8
@MatheusFranco99
dutyexe tests
c95d636
@MatheusFranco99
add test docs; fix msg processing test
e746f6f
@MatheusFranco99
add all tests
e93301b
@MatheusFranco99
generate JSON tests
0ca88b3
@MatheusFranco99
drop weird json tests in unintended directory
cafd39f
@MatheusFranco99
add mixed agg+scc pre-consensus tests
2e3c59e
@MatheusFranco99
generate JSON tests
0b017e7
@MatheusFranco99
add error code
de5bb1d
@MatheusFranco99
increase number of Contributors
36b5db0
@MatheusFranco99
add post-consensus mixed agg committee tests
a1dcc04
@MatheusFranco99
generate JSON tests
c8ced68
@MatheusFranco99
add agg committee duty validation; add psgi msg sorting;
983436a
@MatheusFranco99
add sorting and duty validation tests
725412b
@MatheusFranco99
generate JSON tests
e67f91f
@MatheusFranco99 MatheusFranco99 self-assigned this Jan 2, 2026
@MatheusFranco99 MatheusFranco99 mentioned this pull request Jan 2, 2026
Open
Base automatically changed from agg-comm-improvements to aggregator-committee January 2, 2026 16:44
@GalRogozinski GalRogozinski requested a review from a team January 4, 2026 08:57
GalRogozinski
GalRogozinski reviewed Jan 4, 2026
View reviewed changes
Copy link
Contributor

@GalRogozinski GalRogozinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@MatheusFranco99 MatheusFranco99 marked this pull request as ready for review January 5, 2026 11:42
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Jan 5, 2026

Skipped: This PR changes more files than the configured file change limit: (389 files found, 150 file limit)

GalRogozinski
GalRogozinski reviewed Jan 6, 2026
View reviewed changes
GalRogozinski
GalRogozinski approved these changes Jan 8, 2026
View reviewed changes
Copy link
Contributor

@GalRogozinski GalRogozinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Jan 8, 2026

Too many files changed for review.

@MatheusFranco99 MatheusFranco99 merged commit 2e927f7 into aggregator-committee Jan 8, 2026
2 checks passed
@MatheusFranco99 MatheusFranco99 deleted the committee-runners branch January 8, 2026 08:02
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Jan 8, 2026

Too many files changed for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GalRogozinski GalRogozinski GalRogozinski approved these changes

@y0sher y0sher Awaiting requested review from y0sher

@jking-aus jking-aus Awaiting requested review from jking-aus

Assignees

@MatheusFranco99 MatheusFranco99

Labels

Boole fork

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MatheusFranco99 @GalRogozinski