fix(template/tilt): Support secret-operator helm overrides #554
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Techassi <[email protected]>
Techassi
approved these changes
Oct 17, 2025
Comment on lines
+36
to
+39
| helm_override_image_repository = 'image.repository=' + registry + '/' + operator_name | ||
| if operator_name == "secret-operator": | ||
| # secret-operator image reference is under the secretOperator section | ||
| helm_override_image_repository = "secretOperator." + helm_override_image_repository |
There was a problem hiding this comment.
We could in theory template this via Jinja, but this way is also fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caution
Not yet tested
These changes should have been make at the same time as stackabletech/secret-operator@ee7e164