Skip to content

fix(template/tilt): Support secret-operator helm overrides #554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix(template/tilt): Support secret-operator helm overrides #554

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
92c9faa
fix(template/tilt): Support secret-operator helm overrides, and Daemo…
NickLarsenNZ Oct 15, 2025
49b44c1
chore(template/tilt): Make the helm override for image repository mor…
NickLarsenNZ Oct 15, 2025
cc89a95
chore(template/tilt): Allow a custom helm values file
NickLarsenNZ Oct 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion template/Tiltfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,17 @@ if os.path.exists('result'):
# oci.stackable.tech/sandbox/opa-operator:7y19m3d8clwxlv34v5q2x4p7v536s00g instead of
# oci.stackable.tech/sandbox/opa-operator:0.0.0-dev (which does not exist)
k8s_kind('Deployment', image_json_path='{.spec.template.metadata.annotations.internal\\.stackable\\.tech/image}')
k8s_kind('DaemonSet', image_json_path='{.spec.template.metadata.annotations.internal\\.stackable\\.tech/image}')

# Optionally specify a custom Helm values file to be passed to the Helm deployment below.
# This file can for example be used to set custom telemetry options (like log level) which is not
# supported by helm(set).
helm_values = settings.get('helm_values', None)

helm_override_image_repository = 'image.repository=' + registry + '/' + operator_name
if operator_name == "secret-operator":
# secret-operator image reference is under the secretOperator section
helm_override_image_repository = "secretOperator." + helm_override_image_repository
Comment on lines +36 to +39
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could in theory template this via Jinja, but this way is also fine.


# Exclude stale CRDs from Helm chart, and apply the rest
helm_crds, helm_non_crds = filter_yaml(
Expand All @@ -34,8 +45,9 @@ helm_crds, helm_non_crds = filter_yaml(
name=operator_name,
namespace="stackable-operators",
set=[
'image.repository=' + registry + '/' + operator_name,
helm_override_image_repository,
],
values=helm_values,
),
api_version = "^apiextensions\\.k8s\\.io/.*$",
kind = "^CustomResourceDefinition$",
Expand Down