-
Notifications
You must be signed in to change notification settings - Fork 29
Add manual security group handling and expose SG ID #923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
msk-stackit
wants to merge
21
commits into
stackitcloud:main
Choose a base branch
from
msk-stackit:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marceljk
reviewed
Jul 30, 2025
stackit/internal/services/loadbalancer/loadbalancer/resource.go
Outdated
Show resolved
Hide resolved
stackit/internal/services/loadbalancer/loadbalancer_acc_test.go
Outdated
Show resolved
Hide resolved
stackit/internal/services/loadbalancer/loadbalancer_acc_test.go
Outdated
Show resolved
Hide resolved
stackit/internal/services/loadbalancer/loadbalancer_acc_test.go
Outdated
Show resolved
Hide resolved
marceljk
reviewed
Aug 6, 2025
marceljk
reviewed
Aug 14, 2025
stackit/internal/services/loadbalancer/loadbalancer/resource.go
Outdated
Show resolved
Hide resolved
marceljk
reviewed
Aug 14, 2025
stackit/internal/services/loadbalancer/loadbalancer/resource.go
Outdated
Show resolved
Hide resolved
marceljk
reviewed
Aug 14, 2025
stackit/internal/services/loadbalancer/loadbalancer/resource.go
Outdated
Show resolved
Hide resolved
marceljk
reviewed
Aug 14, 2025
stackit/internal/services/loadbalancer/loadbalancer/resource.go
Outdated
Show resolved
Hide resolved
marceljk
reviewed
Aug 14, 2025
stackit/internal/services/loadbalancer/loadbalancer/resource.go
Outdated
Show resolved
Hide resolved
marceljk
reviewed
Aug 14, 2025
marceljk
reviewed
Aug 14, 2025
marceljk
reviewed
Aug 14, 2025
marceljk
reviewed
Aug 14, 2025
marceljk
reviewed
Aug 14, 2025
marceljk
reviewed
Aug 14, 2025
marceljk
reviewed
Aug 15, 2025
Can you please rebase you branch? |
… the load balancer resource. This allows disabling the automatic assignment of a security group to the targets.
This allows users to reference the ID in security group rules for targets in other networks, enabling cross-network traffic.
This allows users to reference the ID in security group rules for targets in other networks, enabling cross-network traffic.
…es ready if disabletargetsecuritygroupassignment is true
marceljk
approved these changes
Aug 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR enhances the stackit_loadbalancer resource by introducing advanced networking capabilities for managing security groups, particularly for cross-network and cross-project use cases.
Two new attributes have been added:
disable_security_group_assignment (Optional, Bool): This new root-level flag allows users to disable the automatic creation and assignment of security groups to the load balancer's targets. This is required when targets are located in a different network or project than the load balancer itself, giving users full control over the networking setup.
security_group_id (Computed, String): This new computed attribute exposes the ID of the load balancer's own internal egress security group. Users can reference this ID in their own security group rules (e.g., as the remote_security_group_id) to manually permit traffic from the load balancer to their targets.
Together, these features enable secure and explicit network configurations for complex architectures. This change includes updates to the resource and data source schemas, all necessary business logic, comprehensive unit and acceptance tests, and updated documentation to guide users through the new workflow.
relates to #1150
Checklist
make fmt
examples/
directory)make generate-docs
(will be checked by CI)make test
(will be checked by CI)make lint
(will be checked by CI)