Added Security_group_id to tests and added non deprecated machine_type

[bm-stackit]

Description

#923 (comment)
#923 (comment)

It was requested that we add the security group id to the tests and change machine_type to non deprecated ones.

Checklist

• Issue was linked above
• Code format was applied: make fmt
• Examples were added / adjusted (see examples/ directory)
• Docs are up-to-date: make generate-docs (will be checked by CI)
• Unit tests got implemented or updated
• Acceptance tests got implemented or updated (see e.g. here)
• Unit tests are passing: make test (will be checked by CI)
• No linter issues: make lint (will be checked by CI)

[rubenhoenle]

Acc tests are failing, see below

➜  terraform-provider-stackit git:(58de58f8) TF_ACC=1 go test -timeout=90m ./stackit/internal/services/loadbalancer/loadbalancer_acc_test.go
No load balancers found for project
--- FAIL: TestAccLoadBalancerResourceMin (180.32s)
    loadbalancer_acc_test.go:100: Step 1/4 error: After applying this test step, the refresh plan was not empty.
        stdout


        Terraform used the selected providers to generate the following execution
        plan. Resource actions are indicated with the following symbols:
          ~ update in-place

        Terraform will perform the following actions:

          # stackit_network_interface.network_interface will be updated in-place
          ~ resource "stackit_network_interface" "network_interface" {
                id                   = "66b03760-125b-4c63-9624-741e8a418c02,de811328-b8c7-4d48-83ef-9449214f3ae2,8acec57f-dc95-4bdf-a5b6-e9bcda97ba60"
                name                 = "name"
              ~ security_group_ids   = [
                  - "bfd2de46-a802-41d9-b246-8c0e0b615226",
                ]
                # (8 unchanged attributes hidden)
            }

        Plan: 0 to add, 1 to change, 0 to destroy.
No load balancers found for project
--- FAIL: TestAccLoadBalancerResourceMax (190.23s)
    loadbalancer_acc_test.go:218: Step 1/4 error: Check failed: Check 17/41 error: stackit_loadbalancer.loadbalancer: Attribute 'security_group_id' expected "123abc-a123-123a-1234-abc123def456", got "95cfd576-131a-457b-8f18-037b3e25d264"
FAIL
FAIL    command-line-arguments  190.234s
FAIL

[bm-stackit]

Acc tests are failing, see below

➜  terraform-provider-stackit git:(58de58f8) TF_ACC=1 go test -timeout=90m ./stackit/internal/services/loadbalancer/loadbalancer_acc_test.go
No load balancers found for project
--- FAIL: TestAccLoadBalancerResourceMin (180.32s)
    loadbalancer_acc_test.go:100: Step 1/4 error: After applying this test step, the refresh plan was not empty.
        stdout


        Terraform used the selected providers to generate the following execution
        plan. Resource actions are indicated with the following symbols:
          ~ update in-place

        Terraform will perform the following actions:

          # stackit_network_interface.network_interface will be updated in-place
          ~ resource "stackit_network_interface" "network_interface" {
                id                   = "66b03760-125b-4c63-9624-741e8a418c02,de811328-b8c7-4d48-83ef-9449214f3ae2,8acec57f-dc95-4bdf-a5b6-e9bcda97ba60"
                name                 = "name"
              ~ security_group_ids   = [
                  - "bfd2de46-a802-41d9-b246-8c0e0b615226",
                ]
                # (8 unchanged attributes hidden)
            }

        Plan: 0 to add, 1 to change, 0 to destroy.
No load balancers found for project
--- FAIL: TestAccLoadBalancerResourceMax (190.23s)
    loadbalancer_acc_test.go:218: Step 1/4 error: Check failed: Check 17/41 error: stackit_loadbalancer.loadbalancer: Attribute 'security_group_id' expected "123abc-a123-123a-1234-abc123def456", got "95cfd576-131a-457b-8f18-037b3e25d264"
FAIL
FAIL    command-line-arguments  190.234s
FAIL

If the acc tests are still failing and the security_group_Id changed again I will do another PR. That one will only check if the attribute is set since its being computated. Unless there is a way to check for the actual computated security_group_id?

[rubenhoenle]

Acc tests are still failing

➜  terraform-provider-stackit git:(6ca2e58a) TF_ACC=1 go test -timeout=30m ./stackit/internal/services/loadbalancer/loadbalancer_acc_test.go
--- FAIL: TestAccLoadBalancerResourceMin (170.28s)
    loadbalancer_acc_test.go:100: Step 1/4 error: Check failed: Check 19/24 error: stackit_loadbalancer.loadbalancer: Attribute 'security_group_id' found when not expected
No load balancers found for project
FAIL
FAIL    command-line-arguments  200.412s
FAIL