Skip to content

Conversation

@mulkieran
Copy link
Member

@mulkieran mulkieran commented Oct 23, 2025

Summary by CodeRabbit

  • Chores
    • Removed Fedora 41 version comparison steps from continuous integration workflows.

@mulkieran mulkieran self-assigned this Oct 23, 2025
@coderabbitai
Copy link

coderabbitai bot commented Oct 23, 2025

Walkthrough

The pull request removes Fedora 41 version comparison steps from two GitHub Actions workflows. Specifically, it deletes Fedora f41 comparison execution lines from .github/workflows/cargo.yml and .github/workflows/nightly.yml, while preserving all other comparison logic and workflow behavior.

Changes

Cohort / File(s) Summary
Fedora 41 comparison removal
​.github/workflows/cargo.yml, ​.github/workflows/nightly.yml
Removes Fedora f41 version comparison steps from two separate job sections in each workflow file, disabling these specific comparison runs

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested reviewers

  • jbaublitz

Poem

🐰 A hop, skip, and a line removed
F41 comparisons now soothed
Workflows run lean and light,
Without Fedora's nightly flight!
Simpler CI/CD delight. 🚀

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The PR title "Stop checking rust dependency versions on Fedora 41" is directly aligned with the main changes in the changeset. The pull request removes Fedora 41 version comparison steps from two GitHub workflow files (.github/workflows/cargo.yml and .github/workflows/nightly.yml), which is precisely what the title describes. The title is concise, specific, and uses clear language that avoids vague terms, making it immediately understandable to someone reviewing the commit history.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0e84dc6 and 8a4ba5a.

📒 Files selected for processing (2)
  • .github/workflows/cargo.yml (0 hunks)
  • .github/workflows/nightly.yml (0 hunks)
💤 Files with no reviewable changes (2)
  • .github/workflows/nightly.yml
  • .github/workflows/cargo.yml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (40)
  • GitHub Check: rpm-build:fedora-43-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-42-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-rawhide-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-41-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-rawhide-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-42-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-42-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-rawhide-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-43-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-41-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-43-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-41-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-rawhide-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-41-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-41-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-43-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-43-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-rawhide-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-42-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-42-x86_64:copr_pull
  • GitHub Check: fedora (make -f Makefile test-mutex, cryptsetup-devel keyutils-libs-devel, 34)
  • GitHub Check: fedora (make -f Makefile test-loopback, cryptsetup-devel keyutils-libs-devel, 38)
  • GitHub Check: fedora (make -f Makefile release, cryptsetup-devel, 33)
  • GitHub Check: fedora (make -f Makefile test-mutex, cryptsetup-devel keyutils-libs-devel, 38)
  • GitHub Check: fedora (make -f Makefile build-examples, cryptsetup-devel, 38)
  • GitHub Check: fedora (make -f Makefile build, cryptsetup-devel, 33)
  • GitHub Check: fedora (make -f Makefile test-mutex-guard, cryptsetup-devel keyutils-libs-devel, 33)
  • GitHub Check: fedora (make -f Makefile release, cryptsetup-devel, 34)
  • GitHub Check: fedora (make -f Makefile test-loopback, cryptsetup-devel keyutils-libs-devel, 33)
  • GitHub Check: fedora (make -f Makefile test, cryptsetup-devel keyutils-libs-devel, 38)
  • GitHub Check: fedora (make -f Makefile docs-ci, cryptsetup-devel, 33)
  • GitHub Check: fedora (make -f Makefile build, cryptsetup-devel, 34)
  • GitHub Check: fedora (make -f Makefile docs-ci, cryptsetup-devel, 38)
  • GitHub Check: fedora (make -f Makefile release, cryptsetup-devel, 38)
  • GitHub Check: fedora (make -f Makefile test, cryptsetup-devel keyutils-libs-devel, 34)
  • GitHub Check: fedora (make -f Makefile test-loopback, cryptsetup-devel keyutils-libs-devel, 34)
  • GitHub Check: fedora (make -f Makefile docs-ci, cryptsetup-devel, 34)
  • GitHub Check: stable (make -f Makefile test-mutex, libcryptsetup-dev libkeyutils-dev)
  • GitHub Check: lowest_supported (make -f Makefile test-mutex-guard, libcryptsetup-dev libkeyutils-dev)
  • GitHub Check: stable (make -f Makefile test-mutex-guard, libcryptsetup-dev libkeyutils-dev)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@packit-as-a-service
Copy link

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/stratis-storage-libcryptsetup-rs-454
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

@mulkieran mulkieran moved this to In Review in 2025October Oct 23, 2025
@mulkieran mulkieran merged commit 54e2f10 into stratis-storage:master Oct 23, 2025
45 checks passed
@github-project-automation github-project-automation bot moved this from In Review to Done in 2025October Oct 23, 2025
@mulkieran mulkieran moved this from Done to Done(3) in 2025October Oct 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done(3)

Development

Successfully merging this pull request may close these issues.

1 participant