Deduplicate interface_list while preserving order #1072
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Teal Playground URL: https://1072--teal-playground-preview.netlify.app |
Member
You should be able to run it on a Linux environment like so:
(* You may also need to install other dependencies for a full development environment, on a Ubuntu environment you can Let us know if these instructions are sufficient or if you need more help! |
hishamhm
reviewed
Jan 19, 2026
Comment on lines
+1493
to
+1498
| local function collect_interfaces( | ||
| self: Context, | ||
| list: {ArrayType | NominalType}, | ||
| t: RecordLikeType, | ||
| seen: {Type: boolean} | ||
| ): {ArrayType | NominalType} |
Member
There was a problem hiding this comment.
Please do not change the style of these longer lines. (Same with self.errs:add below.) Thank you!
Member
|
Merged manually via 47d784d (which seemed to build upon this PR) — thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR avoids duplicate entries in
interface_listwhen collecting interfaces through multiple inheritance paths.The change preserves the original interface order and does not alter conflict resolution semantics. Only the first occurrence of each interface is retained.
Note: I was not able to run the compiler locally; the change is a minimal refactor that preserves existing behavior.
Fixes #1018.