Skip to content

Deduplicate interface_list while preserving order #1072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Sushil-Rahatole wants to merge 1 commit into from
Closed

Deduplicate interface_list while preserving order #1072

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 17 additions & 5 deletions teal/check/context.tl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1490,19 +1490,31 @@ do
end
end

local function collect_interfaces(self: Context, list: {ArrayType | NominalType}, t: RecordLikeType, seen:{Type:boolean}): {ArrayType | NominalType}
local function collect_interfaces(
self: Context,
list: {ArrayType | NominalType},
t: RecordLikeType,
seen: {Type: boolean}
): {ArrayType | NominalType}
if t.interface_list then
for _, iface in ipairs(t.interface_list) do
if iface is NominalType then
local ri = self:resolve_nominal(iface)
if ri is InterfaceType then
table.insert(list, iface)
if ri.interfaces_expanded and not seen[ri] then
if not seen[ri] then
seen[ri] = true
collect_interfaces(self, list, ri, seen)
table.insert(list, iface)
if ri.interfaces_expanded then
collect_interfaces(self, list, ri, seen)
end
end
else
self.errs:add(iface, "attempted to use %s as interface, but its type is %s", iface, ri)
self.errs:add(
iface,
"attempted to use %s as interface, but its type is %s",
iface,
ri
)
end
else
if not seen[iface] then
Expand Down
Loading