15.0 emoji versions #232

macchiati · 2022-05-02T14:36:15Z

This should work now. You have to supply an environment variable to generate the beta. Added more documentation to the top of Emoji.java.

nedley · 2022-05-02T15:24:18Z

The changes in Emoji.java are identical to what I had on the branch I sent you and I was setting -Demoji-beta. What changed?

nedley · 2022-05-02T15:25:02Z

Is it because I also changed VersionToAge.java? Because I thought I was supposed to…

markusicu · 2022-05-02T15:25:21Z

unicodetools/src/main/java/org/unicode/tools/emoji/Emoji.java

+ * You need a command line variable to generate either the beta version (not yet released) or the abbreviated version (see below).
+ * <p>Example: -Demoji-beta


The emoji-beta option is already mentioned on https://github.com/unicode-org/unicodetools/blob/main/docs/emoji/index.md
Wouldn't it be better to update that and point from here to there?

Note that there are several docs pages under emoji/ : https://github.com/unicode-org/unicodetools/tree/main/docs/emoji

markusicu · 2022-05-02T15:25:57Z

unicodetools/src/main/java/org/unicode/tools/emoji/Emoji.java

+	/**
+	 * The following is used to generate an abbreviated version of the charts, where only a few rows are produced,
+	 * and all images are replaced by a colored square (small data size).
+	 * This version can be used to do link-checks.
+	 */


Please set your editor to write spaces, not tabs, and fix this comment.

nedley · 2022-05-03T21:21:21Z

As I mentioned yesterday, these changes seem like a subset of what I had done on my ned/emoji_15_draft branch so I have to ask: in the generated emoji-data.txt, are you seeing E15.0? and does emoji-test.txt contain 15.0 emoji?

macchiati · 2022-05-04T15:15:27Z

Sorry for being so uncommunicative; I'm overbooked right now. Will have a chance to look at this today. I think there is a switch somewhere to generate the beta data files; it might be key'ed off of the status of the candidates (eg provisional v draft) in the candidateData file, but I have to check. Will have some time later today.

…

On Tue, May 3, 2022 at 2:21 PM Ned Holbrook ***@***.***> wrote: As I mentioned yesterday, these changes seem like a subset of what I had done on my ned/emoji_15_draft branch so I have to ask: in the generated emoji-data.txt, are you seeing E15.0? and does emoji-test.txt contain 15.0 emoji? — Reply to this email directly, view it on GitHub <#232 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACJLEMCRJOJOTQJ7CLJN3YLVIGKFZANCNFSM5U4FKVFQ> . You are receiving this because you authored the thread.Message ID: ***@***.***>

macchiati · 2022-05-06T04:11:04Z

Made modifications to get the files to build. Updated the emoji/index.md. Still need to build emoji-test.txt, but wanted to get these in first. There is a related PR in the emoji repo.

nedley

Thanks for taking the time to flesh this out. Having the 15.0 additions show up as E0.0 is a problem for the beta but we could fix those by hand if time is running low.

nedley · 2022-05-06T05:26:55Z

unicodetools/src/test/java/org/unicode/propstest/CheckPropertyStability.java

@@ -0,0 +1,126 @@
+package org.unicode.propstest;


Is this file required for the E15.0 data?

nedley · 2022-05-06T05:28:58Z

unicodetools/src/main/java/org/unicode/tools/emoji/GenerateEmojiData.java


    public static <T> void printData() throws IOException {
-        printData(EmojiDataSourceCombined.EMOJI_DATA);
+        printData(EmojiDataSourceCombined.EMOJI_DATA_BETA);


I’m assuming this was the missing piece?

nedley · 2022-05-06T05:31:06Z

unicodetools/data/emoji/15.0/emoji-sequences.txt

+1F6D1..1F6D2  ; Basic_Emoji                  ; stop sign                                                      # E3.0   [2] (🛑..🛒)
+1F6D5         ; Basic_Emoji                  ; hindu temple                                                   # E12.0  [1] (🛕)
+1F6D6..1F6D7  ; Basic_Emoji                  ; hut                                                            # E13.0  [2] (🛖..🛗)
+1F6DC         ; Basic_Emoji                  ; wireless                                                       # E0.0   [1] (🛜)


This is still showing E0.0.

unicodetools/data/emoji/15.0/emoji-data.txt

nedley · 2022-05-06T15:33:30Z

unicodetools/src/main/java/org/unicode/tools/emoji/Emoji.java

    public static final VersionInfo VERSION0_6 = VersionInfo.getInstance(0,6);
    public static final VersionInfo VERSION0_5 = VersionInfo.getInstance(0,5,2);

    // ALSO fix VersionToAge.java!


Is this comment still relevant?

nedley · 2022-05-06T15:42:05Z

@macchiati I will approve your current PRs to not hold things up but at this point we still have issues that are probably blockers for the beta release: charts aside, they are the wrong ages and an incomplete emoji-test.txt. Given your limited availability next week, my proposal is that I make the necessary fixes by hand before trying to debug the tooling but if you know where the problem lies then I will obviously defer to you.

nedley · 2022-05-06T15:47:00Z

After scrutinizing the updated comments in the code, it sounds like the emoji-test.txt will be fixed after copying the generated files and re-running the tool?

…update the instructions)

macchiati · 2022-05-06T16:47:12Z

Yes, the E0.0 and missing values in the test are fixed by running the tool again. There is one extra step that I now document in the index.md. See how it looks now.

Haven't tracked down the X issue in the charts yet, but I think this part should be good enough to check in (after checking, of course).

And will fix the X later today.

markusicu · 2022-05-11T18:54:06Z

@nedley @macchiati sorry for not noticing this before -- but the data files are in the wrong place!
You put them into https://github.com/unicode-org/unicodetools/tree/main/unicodetools/data/emoji/15.0 as in the old days, but we had decided last year to stop doing that, and put development versions into "dev" folders. These should have gone into https://github.com/unicode-org/unicodetools/tree/main/unicodetools/data/emoji/dev

You should also have populated the files in https://github.com/unicode-org/unicodetools/tree/main/unicodetools/data/ucd/dev/emoji
as far as some files are still duplicated in multiple locations.

Please fix!

nedley · 2022-05-11T19:02:18Z

#241 (comment)

markusicu · 2022-05-11T20:29:20Z

I have sent PR #248 for review to move the emoji files to where they belong, sync the duplicated files, and update the readmes.

15.0 emoji versions

796475f

macchiati requested a review from nedley May 2, 2022 14:36

markusicu reviewed May 2, 2022

View reviewed changes

macchiati added 2 commits May 5, 2022 20:57

Update emoji to 15.0

c67d675

Add emoji chart destination

c7d6302

macchiati requested a review from markusicu May 6, 2022 04:09

nedley reviewed May 6, 2022

View reviewed changes

Take second pass to fix E0.0 and generate proper emoji-test.txt (and …

298c443

…update the instructions)

macchiati requested a review from nedley May 6, 2022 16:47

nedley approved these changes May 6, 2022

View reviewed changes

macchiati merged commit f0fb440 into unicode-org:main May 6, 2022

macchiati deleted the 15.0-emoji-versions branch May 6, 2022 18:19

nedley mentioned this pull request May 10, 2022

Update emoji data and chart posting instructions #241

Open

markusicu mentioned this pull request May 11, 2022

move emoji/15.0 files to emoji/dev #248

Merged

markusicu mentioned this pull request May 16, 2022

Clean up the Emoji tooling #239

Closed

		* You need a command line variable to generate either the beta version (not yet released) or the abbreviated version (see below).
		* <p>Example: -Demoji-beta

Uh oh!

15.0 emoji versions #232

15.0 emoji versions #232

Uh oh!

Conversation

macchiati commented May 2, 2022

Uh oh!

nedley commented May 2, 2022

Uh oh!

nedley commented May 2, 2022

Uh oh!

markusicu May 2, 2022

Choose a reason for hiding this comment

Uh oh!

markusicu May 2, 2022

Choose a reason for hiding this comment

Uh oh!

nedley commented May 3, 2022

Uh oh!

macchiati commented May 4, 2022 via email

Uh oh!

macchiati commented May 6, 2022

Uh oh!

nedley left a comment

Choose a reason for hiding this comment

Uh oh!

nedley May 6, 2022

Choose a reason for hiding this comment

Uh oh!

nedley May 6, 2022

Choose a reason for hiding this comment

Uh oh!

nedley May 6, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

nedley May 6, 2022

Choose a reason for hiding this comment

Uh oh!

nedley commented May 6, 2022

Uh oh!

nedley commented May 6, 2022

Uh oh!

macchiati commented May 6, 2022

Uh oh!

markusicu commented May 11, 2022

Uh oh!

nedley commented May 11, 2022

Uh oh!

markusicu commented May 11, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants