Update emoji data and chart posting instructions #241
Conversation
macchiati
changed the title
| Check the readme file if it exists, which should say draft. | ||
| ## Posting Emoji beta data | ||
|
|
||
| Copy all files under https://github.com/unicode-org/unicodetools/tree/main/unicodetools/data/emoji/15.0 files to Public |
There was a problem hiding this comment.
| Copy all files under https://github.com/unicode-org/unicodetools/tree/main/unicodetools/data/emoji/15.0 files to Public | |
| Copy all files under https://github.com/unicode-org/unicodetools/tree/main/unicodetools/data/emoji/dev files to Public |
Remember that we don't copy to .../data/category/15.0 until after the 15.0 release.
There was a problem hiding this comment.
I’m happy to help in Mark’s absence but am confused as to what needs to happen here. docs/build.md still says “We now generate files into an output folder with the Unicode version number” and #232 committed files to that directory, do you also want those files moved to match this proposed change?
There was a problem hiding this comment.
In the Generated output folder, we use versioned subfolders.
In the repo, the unreleased data files all go into dev subfolders. We have done this for all data files since we agreed last November to do so.
I can make a PR and shuffle these files.
There was a problem hiding this comment.
I can make a PR and shuffle these files.
Actually, not for this pending PR. I can make a PR to move the files that got merged into the wrong place in PR #232.
| * Copy the following to https://unicode.org/Public/emoji/15.0/ | ||
| * ReadMe.txt | ||
| * emoji-sequences.txt | ||
| * emoji-test.txt | ||
| * emoji-zwj-sequences.txt |
There was a problem hiding this comment.
Comment from @rickmcgowan via email:
I'd suggest adding a note to the effect that the above files are part of the UCD, so vetting and posting needs to be done in coordination with the release of the standard. At this point Ken Whistler and the UTC release management team are in charge of that.
The other emoji data files go with the versioned Emoji release. And the charts are sort of evergreen and can be changed between releases.
My partial response: Whenever we "copy to Public" we really should copy to a staging area, and someone (currently Ken or Rick) then actually copies to Public. We can make this explicit everywhere, or just remember that intermediate step.
| * First sanity-check the files. | ||
| * The Readme.txt should say "draft" in the contents, and have the version 15.0. | ||
| * The other files should have the new 15.0 characters and sequences. | ||
| * The previous characters should be unchanged, except that the CLDR names may change. |
There was a problem hiding this comment.
Comment from @rickmcgowan via email:
The bits about sanity checking and such are initially handled by whomever is creating the charts. Then the person posting them live also does some checking when posting them to the server for public release. I think at this point some/all of validation and link checking can be done on the GitHub versions? Might be worth noting that the charts themselves are far too large for the W3C link checker, hence the "flag" charts should be link-checked, and that can be coordinated between the person delivering the charts and the person doing the public release/copy operations.
|
Thanks, Markus
…On Wed, May 11, 2022 at 12:58 PM Markus Scherer ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In docs/emoji/charts-and-data.md
<#241 (comment)>
:
> First time posting a new set of beta charts, make sure that charts-beta is a
newly created symlink to charts-BBBB.
-## Emoji beta data
-
-Copy all files under draft/Public/emoji/NN.N files to live Public/emoji/NN.NN
-* don't copy anything under the "internal" directory.
-
-Check the readme file if it exists, which should say draft.
+## Posting Emoji beta data
+
+Copy all files under https://github.com/unicode-org/unicodetools/tree/main/unicodetools/data/emoji/15.0 files to Public
I can make a PR and shuffle these files.
Actually, not for this pending PR. I can make a PR to move the files that
got merged into the wrong place in PR #232
<#232>.
—
Reply to this email directly, view it on GitHub
<#241 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACJLEME4NOUMB54V33XSDZTVJQGPNANCNFSM5VMJYCSQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
| * emoji-test.txt | ||
| * emoji-zwj-sequences.txt | ||
| * Copy the following to https://unicode.org/Public/15.0.0/ucd/emoji/ | ||
| * ReadMe-ucd-emoji.txt // and change the name to drop the "-ucd-emoji" |
There was a problem hiding this comment.
I am deleting this file in PR #248. It was exactly the same as ucd/dev/emoji/ReadMe.txt.
More generally, we should just copy all of the three files in ucd/dev/emoji/ to Public/{version}/ucd/emoji/ .
Remember that we have issue #152 for de-duplicating the two data files here so that we not track them in the repo in two places.
|
@nedley can you please take over this PR and address the feedback? |
|
FYI @macchiati here is an earlier post about the current file process/workflow and writing files into the repo vs. into "Generated": #239 (comment) |
|
This is still on my list, yes. |
ping @nedley ...? |
No description provided.