Skip to content

Update emoji data and chart posting instructions #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
macchiati wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update emoji data and chart posting instructions #241

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3c6c9fb
Update emoji chart instructions.
macchiati May 8, 2022
bf6b05a
Add note on images
macchiati May 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
61 changes: 40 additions & 21 deletions docs/emoji/charts-and-data.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,32 +1,51 @@
# Emoji Charts and Data
# Posting Emoji Charts and Data

## Emoji beta charts
The following use 15.0 as the example version. Change that to whatever the version is.

always check and post the files that have changed in:
## Posting Emoji beta charts

<https://www.unicode.org/draft/emoji/>
Check and post the chart files that have changed in:

* \*.html
* charts-BBBB/\* (except /internal/) - where BBBB is the beta release version
— in this case 12.0
* [future/](https://www.unicode.org/draft/emoji/future/)\* (except /internal/)
* [images/](https://www.unicode.org/draft/emoji/images/)\*
https://github.com/unicode-org/emoji/tree/main/docs/emoji/

In this case you should also post the following (just regenerated) since there
are new images, and some changes in layout.
That is:

* charts-RRRR/\* (except /internal/) - where RRRR is the current release
version — in this case 11.0
* First sanity-check the charts.
* You can do a link check on the "flagged" charts, since they are built to be small.
* Visually inspect them also;
* make sure that the new characters are in,
* version numbers are right,
* and images are present (at least one per row)
* https://github.com/unicode-org/emoji/tree/main/docs/emoji/charts-15.0
* All files with .html
* Skip other files, and /internal/
* https://github.com/unicode-org/emoji/tree/main/docs/emoji/future
* All files with .html

(linking checking to be done with the "flag" versions. please let me know of any
problems (though if there are no visible artifacts it isn't a showstopper))
NOTE: make sure that all the emoji images are in a proper directory with proper names:
* **not** proposed/proposed_...png, but rather
* sample/sample_...png, or
* android/androic_...png, or
* ...

[Not sure this comment is still relevant]
First time posting a new set of beta charts, make sure that charts-beta is a
newly created symlink to charts-BBBB.

## Emoji beta data

Copy all files under draft/Public/emoji/NN.N files to live Public/emoji/NN.NN
* don't copy anything under the "internal" directory.

Check the readme file if it exists, which should say draft.
## Posting Emoji beta data

Copy all files under https://github.com/unicode-org/unicodetools/tree/main/unicodetools/data/emoji/15.0 files to Public
Copy link
Member

@markusicu markusicu May 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Copy all files under https://github.com/unicode-org/unicodetools/tree/main/unicodetools/data/emoji/15.0 files to Public
Copy all files under https://github.com/unicode-org/unicodetools/tree/main/unicodetools/data/emoji/dev files to Public

Remember that we don't copy to .../data/category/15.0 until after the 15.0 release.

Copy link
Contributor

@nedley nedley May 10, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m happy to help in Mark’s absence but am confused as to what needs to happen here. docs/build.md still says “We now generate files into an output folder with the Unicode version number” and #232 committed files to that directory, do you also want those files moved to match this proposed change?

Copy link
Member

@markusicu markusicu May 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the Generated output folder, we use versioned subfolders.
In the repo, the unreleased data files all go into dev subfolders. We have done this for all data files since we agreed last November to do so.
I can make a PR and shuffle these files.

Copy link
Member

@markusicu markusicu May 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can make a PR and shuffle these files.

Actually, not for this pending PR. I can make a PR to move the files that got merged into the wrong place in PR #232.

* First sanity-check the files.
* The Readme.txt should say "draft" in the contents, and have the version 15.0.
* The other files should have the new 15.0 characters and sequences.
* The previous characters should be unchanged, except that the CLDR names may change.
Comment on lines +38 to +41
Copy link
Member

@markusicu markusicu May 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment from @rickmcgowan via email:

The bits about sanity checking and such are initially handled by whomever is creating the charts. Then the person posting them live also does some checking when posting them to the server for public release. I think at this point some/all of validation and link checking can be done on the GitHub versions? Might be worth noting that the charts themselves are far too large for the W3C link checker, hence the "flag" charts should be link-checked, and that can be coordinated between the person delivering the charts and the person doing the public release/copy operations.

* Don't copy anything under the /internal/ directory.
* Copy the following to https://unicode.org/Public/emoji/15.0/
* ReadMe.txt
* emoji-sequences.txt
* emoji-test.txt
* emoji-zwj-sequences.txt
Comment on lines +43 to +47
Copy link
Member

@markusicu markusicu May 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment from @rickmcgowan via email:

I'd suggest adding a note to the effect that the above files are part of the UCD, so vetting and posting needs to be done in coordination with the release of the standard. At this point Ken Whistler and the UTC release management team are in charge of that.
The other emoji data files go with the versioned Emoji release. And the charts are sort of evergreen and can be changed between releases.

My partial response: Whenever we "copy to Public" we really should copy to a staging area, and someone (currently Ken or Rick) then actually copies to Public. We can make this explicit everywhere, or just remember that intermediate step.

* Copy the following to https://unicode.org/Public/15.0.0/ucd/emoji/
* ReadMe-ucd-emoji.txt // and change the name to drop the "-ucd-emoji"
Copy link
Member

@markusicu markusicu May 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am deleting this file in PR #248. It was exactly the same as ucd/dev/emoji/ReadMe.txt.

More generally, we should just copy all of the three files in ucd/dev/emoji/ to Public/{version}/ucd/emoji/ .

Remember that we have issue #152 for de-duplicating the two data files here so that we not track them in the repo in two places.

* emoji-data.txt
* emoji-variation-sequences.txt