Skip to content

added pole target feature with pole angle#3

Open
ademola-lou wants to merge 1 commit intoupf-gti:mainfrom
ademola-lou:feat-pole-target
Open

added pole target feature with pole angle#3
ademola-lou wants to merge 1 commit intoupf-gti:mainfrom
ademola-lou:feat-pole-target

Conversation

@ademola-lou
Copy link
Copy Markdown

added pole target feature, the pole target controls the bending direction of the ik chain making it more predictable.

@ademola-lou
Copy link
Copy Markdown
Author

Test
https://github.com/user-attachments/assets/0c9bbf37-5d12-42aa-9107-bfadc60903eb

@japopra
Copy link
Copy Markdown
Collaborator

japopra commented Nov 27, 2025

Hi, it has been some busy months, so we did not have time to review this PR until now.

After reviewing the code, the idea really seems promising, but we cannot merge these features yet:

  • The poleAngle attribute feels a bit redundant. Users could simply update the poleTarget.
  • It would be better if it could generalise to any chain instead of hardcoding it for three bones.
  • If poleDirection is aligned with the chainAxis, maybe it could simply abort, instead of trying to find a "valid" direction.
  • There is an issue with the projectedLength computation, as it assumes that the line between chain[1] and midPoint is perfectly perpendicular to chainAxis, which is not always true. Thus, at the last line, when recomputing the chain[1] position, the resulting point lies in the correct plane but in the wrong location (see attached image).

If you are available to address these concerns, we can keep talking of your contribution :)

ikPoleTargetBug

@japopra japopra linked an issue Dec 9, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pole target support?

2 participants