Skip to content

Conversation

kmakowski
Copy link

No description provided.

@johnoliver
Copy link

+1 on this bug fix, can confirm this is an issue and this fixes it, could be improved with:

project.getBasedir().getAbsolutePath() + File.separator + "target"

But other than that works well

@kmakowski
Copy link
Author

thanks John. Also "target" should not be hardcoded.

@johnoliver
Copy link

This is true, add the parameter to the mojo ${project.build.directory}

@purplefox
Copy link
Member

Thanks. kmakowski - have you signed the Eclipse CLA?

@sjonnalagadda
Copy link

I have signed CLA and here is the pull request.
#25

@kmakowski
Copy link
Author

Yes, I have signed the Eclipse CLA.

purplefox added a commit that referenced this pull request Mar 26, 2014
Fixed broken build fatJar maven goal when vertx maven project is a subproject of other project
@purplefox purplefox merged commit c9e6157 into vert-x:master Mar 26, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants