Skip to content

Fixed broken build fatJar maven goal when vertx maven project is a subproject of other project #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 26, 2014
Merged

Fixed broken build fatJar maven goal when vertx maven project is a subproject of other project #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9ce2262
Fixed build fatJar error when running vertx maven project as submodule
Jan 26, 2014
5fa40f9
Release 2.0.4-final
purplefox Jan 30, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion archetype/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@

<groupId>io.vertx</groupId>
<artifactId>vertx-maven-archetype</artifactId>
<version>2.0.3-final</version>
<version>2.0.4-final</version>
<packaging>maven-archetype</packaging>

<name>vertx-maven-archetype</name>
Expand Down
4 changes: 2 additions & 2 deletions archetype/src/main/resources/archetype-resources/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,15 +36,15 @@
<mods.directory>target/mods</mods.directory>

<!--Dependency versions-->
<vertx.version>2.1M3</vertx.version>
<vertx.version>2.1M5</vertx.version>
<vertx.testtools.version>2.0.3-final</vertx.testtools.version>
<junit.version>4.11</junit.version>

<!--Plugin versions-->
<maven.compiler.plugin.version>3.0</maven.compiler.plugin.version>
<maven.resources.plugin.version>2.6</maven.resources.plugin.version>
<maven.clean.plugin.version>2.5</maven.clean.plugin.version>
<maven.vertx.plugin.version>2.0.3-final</maven.vertx.plugin.version>
<maven.vertx.plugin.version>2.0.4-final</maven.vertx.plugin.version>
<maven.surefire.plugin.version>2.14</maven.surefire.plugin.version>
<maven.failsafe.plugin.version>2.14</maven.failsafe.plugin.version>
<maven.surefire.report.plugin.version>2.14</maven.surefire.report.plugin.version>
Expand Down
4 changes: 2 additions & 2 deletions plugin/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@

<groupId>io.vertx</groupId>
<artifactId>vertx-maven-plugin</artifactId>
<version>2.0.3-final</version>
<version>2.0.4-final</version>
<packaging>maven-plugin</packaging>

<name>vertx-maven-plugin</name>
Expand All @@ -36,7 +36,7 @@

<properties>
<maven.version>2.2.1</maven.version>
<vertx.version>2.1M3</vertx.version>
<vertx.version>2.1M5</vertx.version>
</properties>

<build>
Expand Down
2 changes: 1 addition & 1 deletion plugin/src/main/java/org/vertx/maven/plugin/mojo/VertxFatJarMojo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ public void execute() throws MojoExecutionException {
final PlatformManager pm = factory.createPlatformManager();

final CountDownLatch latch = new CountDownLatch(1);
pm.makeFatJar(moduleName, "target",
pm.makeFatJar(moduleName, project.getBasedir().getAbsolutePath() + "/target",
new Handler<AsyncResult<Void>>() {
@Override
public void handle(final AsyncResult<Void> event) {
Expand Down