Align mobile SDK size recommendation API requests with web implementation by mikhail-yevstratiev · Pull Request #165 · virtusize/integration_android

mikhail-yevstratiev · 2025-08-03T19:02:43Z

🔗 Related Links

ClickUp

⬅️ As Is

Explain the current situation of the code

Android SDK uses outdated size recommendation API requests

➡️ To Be

Android SDK size recommendation API requests are aligned with web implementation

☑️ Checklist

Useless comments and/or Log.d etc are removed
Unit test are covered
Code has been deployed and tested on STG
ClickUp ticket status has been updated to production
Update CHANGELOG.md with the new changes

Copilot

Pull Request Overview

This PR aligns the Android SDK's size recommendation API requests with the web implementation by updating parameter naming conventions and adding support for shoe size recommendations.

Key changes:

Renamed API methods to distinguish between item and shoe size recommendations
Updated API parameter names from camelCase to snake_case to match web standards
Added footwear data support to user body profiles

Reviewed Changes

Copilot reviewed 17 out of 17 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
VirtusizeAPIService.kt	Renamed method and added new shoe size recommendation API method
VirtusizeAPIServiceImpl.kt	Implemented separate endpoints for item and shoe size recommendations
BodyProfileRecommendedSizeParams.kt	Updated parameter naming to snake_case and added shoe-specific parameter mapping
UserBodyProfile.kt	Added footwear data field to support shoe recommendations
VirtusizeApi.kt	Added new API endpoint for shoe size recommendations
Test files	Updated tests to reflect new parameter naming and added footwear data assertions

Copilot · 2025-08-03T19:03:58Z

+            val jsn = JSONObject(apiRequest.params).toString();
+            print(jsn);


Debug code should be removed from production. The line creating jsn variable and the print(jsn) statement appear to be debugging code that should not be included in the final implementation.

Suggested change

val jsn = JSONObject(apiRequest.params).toString();

print(jsn);

Copilot · 2025-08-03T19:03:59Z

        withContext(Dispatchers.IO) {
            val apiRequest = VirtusizeApi.getSize(productTypes, storeProduct, userBodyProfile)
+            val jsn = JSONObject(apiRequest.params).toString();
+            print(jsn);


Debug code should be removed from production. This print statement appears to be debugging code that should not be included in the final implementation.

Suggested change

print(jsn);

Copilot · 2025-08-03T19:03:59Z

+            val jsn = JSONObject(apiRequest.params).toString();
+            print(jsn);


Debug code should be removed from production. The line creating jsn variable and the print(jsn) statement appear to be debugging code that should not be included in the final implementation.

Suggested change

val jsn = JSONObject(apiRequest.params).toString();

print(jsn);

Copilot · 2025-08-03T19:03:59Z

+        withContext(Dispatchers.IO) {
+            val apiRequest = VirtusizeApi.getShoeSize(productTypes, storeProduct, userBodyProfile)
+            val jsn = JSONObject(apiRequest.params).toString();
+            print(jsn);


Debug code should be removed from production. This print statement appears to be debugging code that should not be included in the final implementation.

Suggested change

print(jsn);

Copilot · 2025-08-03T19:04:00Z

-                    userBodyProfileResponse.successData!!,
-                )
-            return bodyProfileRecommendedSizeResponse.successData?.get(0)?.sizeName
+            if (storeProduct.productType == 17) {


Magic number 17 should be replaced with a named constant or enum value to improve code readability and maintainability. Consider defining a constant like PRODUCT_TYPE_SHOES = 17 or using an enum.

Suggested change

if (storeProduct.productType == 17) {

if (storeProduct.productType == PRODUCT_TYPE_SHOES_ID) {

Copilot · 2025-08-03T19:04:00Z

+                "toeShape" to "greek",
+                "size" to "30.5",
+                "type" to "sneakers",
+                "brand" to "virtusize",


Brand name inconsistency: 'virtusize' should be capitalized as 'Virtusize' to match the brand name used elsewhere in the codebase (line 99 shows 'Virtusize').

Suggested change

"brand" to "virtusize",

"brand" to "Virtusize",

@mikhail-yevstratiev please update the brand name

Copilot · 2025-08-03T19:04:00Z

    fun paramsToMap(): Map<String, Any> {
        return emptyMap<String, Any>()
+            .plus(
+                mapOf("app_origin" to 2),


Magic number 2 should be replaced with a named constant to improve code readability and maintainability. Consider defining a constant like APP_ORIGIN_ANDROID = 2.

Suggested change

mapOf("app_origin" to 2),

mapOf("app_origin" to APP_ORIGIN_ANDROID),

@mikhail-yevstratiev resolve the comment

devAbhimanyu

minor comments

devAbhimanyu · 2025-08-04T02:01:48Z

+                "toeShape" to "greek",
+                "size" to "30.5",
+                "type" to "sneakers",
+                "brand" to "virtusize",


@mikhail-yevstratiev please update the brand name

devAbhimanyu · 2025-08-04T02:51:03Z

+     * @param userBodyProfile [UserBodyProfile]
+     * @see ApiRequest
+     */
+    fun getShoeSize(


getShoeSize -> getShoeSizeRecommendation

devAbhimanyu · 2025-08-04T02:51:33Z

    fun paramsToMap(): Map<String, Any> {
        return emptyMap<String, Any>()
+            .plus(
+                mapOf("app_origin" to 2),


@mikhail-yevstratiev resolve the comment

devAbhimanyu

lgtm

mikhail-yevstratiev added 3 commits August 3, 2025 21:55

Make mobile SDK size recommendation requests similar to web

5a709a1

Update tests according to changed API requests

44db623

Update CHANGELOG.md

c8772c1

mikhail-yevstratiev requested review from Copilot and devAbhimanyu August 3, 2025 19:02

mikhail-yevstratiev self-assigned this Aug 3, 2025

Copilot AI reviewed Aug 3, 2025

View reviewed changes

mikhail-yevstratiev added 2 commits August 3, 2025 22:21

Code cleanup

f7b0871

Fix klint

d2659ab

devAbhimanyu requested changes Aug 4, 2025

View reviewed changes

Update naming

8a5102e

mikhail-yevstratiev requested a review from devAbhimanyu August 4, 2025 06:08

devAbhimanyu approved these changes Aug 4, 2025

View reviewed changes

mikhail-yevstratiev merged commit 3b62afa into trunk Aug 4, 2025
3 checks passed

mikhail-yevstratiev deleted the fix/implement-relevant-size-recommendation-API-requests branch August 4, 2025 07:26

mikhail-yevstratiev mentioned this pull request Aug 4, 2025

Release 2.12.3 #166

Merged

6 tasks

		val jsn = JSONObject(apiRequest.params).toString();
		print(jsn);

	if (storeProduct.productType == 17) {
	if (storeProduct.productType == PRODUCT_TYPE_SHOES_ID) {

	mapOf("app_origin" to 2),
	mapOf("app_origin" to APP_ORIGIN_ANDROID),

Uh oh!

Conversation

mikhail-yevstratiev commented Aug 3, 2025

🔗 Related Links

⬅️ As Is

➡️ To Be

☑️ Checklist

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Aug 3, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 3, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 3, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 3, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 3, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 3, 2025

Choose a reason for hiding this comment

Uh oh!

devAbhimanyu Aug 4, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 3, 2025

Choose a reason for hiding this comment

Uh oh!

devAbhimanyu Aug 4, 2025

Choose a reason for hiding this comment

Uh oh!

devAbhimanyu left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

devAbhimanyu Aug 4, 2025

Choose a reason for hiding this comment

Uh oh!

devAbhimanyu Aug 4, 2025

Choose a reason for hiding this comment

Uh oh!

devAbhimanyu Aug 4, 2025

Choose a reason for hiding this comment

Uh oh!

devAbhimanyu left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants