-
Notifications
You must be signed in to change notification settings - Fork 3
Align mobile SDK size recommendation API requests with web implementation #165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mikhail-yevstratiev
merged 6 commits into
trunk
from
fix/implement-relevant-size-recommendation-API-requests
Aug 4, 2025
Merged
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
5a709a1
Make mobile SDK size recommendation requests similar to web
mikhail-yevstratiev 44db623
Update tests according to changed API requests
mikhail-yevstratiev c8772c1
Update CHANGELOG.md
mikhail-yevstratiev f7b0871
Code cleanup
mikhail-yevstratiev d2659ab
Fix klint
mikhail-yevstratiev 8a5102e
Update naming
mikhail-yevstratiev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -428,4 +428,26 @@ object VirtusizeApi { | |
| .toString() | ||
| return ApiRequest(url, HttpMethod.POST, bodyProfileRecommendedSizeParams.paramsToMap()) | ||
| } | ||
|
|
||
| /** | ||
| * Gets a API request for getting the recommended shoe size based on the user's body profile | ||
| * @param productTypes the list of available [ProductType] | ||
| * @param storeProduct [Product] | ||
| * @param userBodyProfile [UserBodyProfile] | ||
| * @see ApiRequest | ||
| */ | ||
| fun getShoeSize( | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. getShoeSize -> getShoeSizeRecommendation |
||
| productTypes: List<ProductType>, | ||
| storeProduct: Product, | ||
| userBodyProfile: UserBodyProfile, | ||
| ): ApiRequest { | ||
| val bodyProfileRecommendedSizeParams = | ||
| BodyProfileRecommendedSizeParams(productTypes, storeProduct, userBodyProfile) | ||
| val url = | ||
| Uri.parse("${environment.sizeRecommendationApiBaseUrl()}${VirtusizeEndpoint.GetShoeSize.path}") | ||
| .buildUpon() | ||
| .build() | ||
| .toString() | ||
| return ApiRequest(url, HttpMethod.POST, bodyProfileRecommendedSizeParams.paramsToMapShoe()) | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Magic number 2 should be replaced with a named constant to improve code readability and maintainability. Consider defining a constant like
APP_ORIGIN_ANDROID = 2.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mikhail-yevstratiev resolve the comment