fix(rsc): optimize react-dom/server
#675
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
optimizeDeps.include
heuristics to ensure popular cjs packages to be automatically optimized #610For example, this is used by tanstack https://github.com/TanStack/router/blob/8efac91d6d7d3e12ed5ef1964392241142492f6a/packages/react-router/src/ssr/renderRouterToStream.tsx#L2.
I remember one annoying thing about React node build is that it includes node builtin without
node:...
prefix, so it can ends up optimizing with node polyfill package, which then actually breaks code e.g.util
not implementingTextEncoder
properly https://github.com/browserify/node-util. But I think it's fine it only happens when users installsutil
in their ownnode_modules
.