-
-
Notifications
You must be signed in to change notification settings - Fork 168
fix(rsc): support cjs on module runner #687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+263
−91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: |
This was referenced Aug 10, 2025
Draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related
optimizeDeps.include
heuristics to ensure popular cjs packages to be automatically optimized #610Since we already have warning for this case #635, we don't lose anything by trying to support this by best effort.
TODO
use-sync-external-store
)use cjs-module-lexer to find export name and re-exports(no for now)I confirmed
keen-slider/react
works withoutoptimizeDeps.include
https://stackblitz.com/edit/github-opzbabz7-rd2xstwo?file=vite.config.ts (thought it still warns it)It looks like
react-dom/server
even works with this, so we can close that tooreact-dom/server
#675