[GPTQ] Fix actorder resolution, add sentinel #1453
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kyle Sayers <[email protected]>
|
👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review. Note: This is required to complete the testing suite, please only add the label once the PR is code complete and local testing has been performed. |
Signed-off-by: Kyle Sayers <[email protected]>
kylesayrs
changed the title
Signed-off-by: Kyle Sayers <[email protected]>
Signed-off-by: Kyle Sayers <[email protected]>
dsikka
reviewed
May 20, 2025
dsikka
requested changes
May 20, 2025
Signed-off-by: Kyle Sayers <[email protected]>
brian-dellabetta
approved these changes
May 22, 2025
dsikka
approved these changes
May 22, 2025
kylesayrs
added a commit
that referenced
this pull request
May 30, 2025
## Purpose ## * Clarify behavior introduced by #1453 ## Changes ## * Remove `TestQuantizationRegistered` test, which is less necessary that it was before * Add `test_actorder_resolution`, which demonstrates and regression tests behavior related to resolving the `actorder` argument --------- Signed-off-by: Kyle Sayers <[email protected]> Co-authored-by: Dipika Sikka <[email protected]>
aireilly
pushed a commit
to aireilly/llm-compressor
that referenced
this pull request
Jul 30, 2025
## Purpose ## * Fix false assumption that `actorder` field is of enum type * Despite the fact that actorder passes through a [field_validator](https://github.com/neuralmagic/compressed-tensors/blob/main/src/compressed_tensors/quantization/quant_args.py#L200), `QuantizationArgs` has the [use_enum_values](https://github.com/neuralmagic/compressed-tensors/blob/main/src/compressed_tensors/quantization/quant_args.py#L128) configuration set, meaning that enum values are converted to strings. * This was done in relation to [this fix](neuralmagic/sparseml#2327) * Remove conflict with recipes which manually specify activation ordering by using a sentinel value ## Follow ups ## * vllm-project#1425 ## Testing ## * Ran llama3 example with manually specified `actorder=group` --------- Signed-off-by: Kyle Sayers <[email protected]> Co-authored-by: Dipika Sikka <[email protected]>
aireilly
pushed a commit
to aireilly/llm-compressor
that referenced
this pull request
Jul 30, 2025
## Purpose ## * Clarify behavior introduced by vllm-project#1453 ## Changes ## * Remove `TestQuantizationRegistered` test, which is less necessary that it was before * Add `test_actorder_resolution`, which demonstrates and regression tests behavior related to resolving the `actorder` argument --------- Signed-off-by: Kyle Sayers <[email protected]> Co-authored-by: Dipika Sikka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
actorderfield is of enum typeQuantizationArgshas the use_enum_values configuration set, meaning that enum values are converted to strings.Follow ups
Testing
actorder=group