Skip to content

[Bugfix] Fix eviction cached blocked logic #21357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 22, 2025

Conversation

simon-mo
Copy link
Collaborator

@simon-mo simon-mo commented Jul 22, 2025

There was a logic error in #21281 causing crashes that triggered by retaining blocks where hashes are already reset.

Tested manually. Crashes before when running large set of benchmarks, no more crashes afterward.

Signed-off-by: simon-mo <[email protected]>
@mergify mergify bot added performance Performance-related issues v1 labels Jul 22, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request fixes a critical logic error in the KV cache eviction mechanism. It also enhances the benchmarking scripts, including the ability to clamp the maximum output length and display request statistics. I've identified potential issues in the new benchmarking code related to input validation and handling edge cases and have provided suggestions to address them.

Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

Copy link
Member

@njhill njhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @simon-mo. Was my typo in a review suggestion ... should have been not blocks_by_id of course 😅

@simon-mo simon-mo merged commit 32142b3 into vllm-project:main Jul 22, 2025
9 of 11 checks passed
yeqcharlotte pushed a commit to yeqcharlotte/vllm that referenced this pull request Jul 23, 2025
zixi-qi pushed a commit to zixi-qi/vllm that referenced this pull request Jul 23, 2025
LyrisZhong pushed a commit to LyrisZhong/vllm that referenced this pull request Jul 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Performance-related issues v1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants