-
-
Notifications
You must be signed in to change notification settings - Fork 9k
[Bugfix] Fix eviction cached blocked logic #21357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: simon-mo <[email protected]>
Signed-off-by: simon-mo <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request fixes a critical logic error in the KV cache eviction mechanism. It also enhances the benchmarking scripts, including the ability to clamp the maximum output length and display request statistics. I've identified potential issues in the new benchmarking code related to input validation and handling edge cases and have provided suggestions to address them.
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @simon-mo. Was my typo in a review suggestion ... should have been not blocks_by_id
of course 😅
Signed-off-by: simon-mo <[email protected]>
Signed-off-by: simon-mo <[email protected]> Signed-off-by: qizixi <[email protected]>
Signed-off-by: simon-mo <[email protected]>
There was a logic error in #21281 causing crashes that triggered by retaining blocks where hashes are already reset.
Tested manually. Crashes before when running large set of benchmarks, no more crashes afterward.